Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Routing Doc and remove duplicate stub #19918

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

laurieontech
Copy link
Contributor

Description

This existing page can be more appropriately named to match its content. It's first header "Creating Dynamic Navigation in Gatsby" should be the page title, and the now redundant stub for "Rendering Sidebar Navigation Dynamically" can be removed.

Related Issues

Addresses #18993

@laurieontech laurieontech requested review from a team as code owners December 2, 2019 14:56
fk
fk previously approved these changes Dec 2, 2019
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an appropriate change to me! One thing worth noting is that docs getting renamed can break old links. Doing a global search of the repo, it looks like the old name isn't linked anywhere in our docs, but we often will use a createRedirect in the gatsby-node file to make sure that the any traffic to the old page (from old links on other's blog posts or wherever they might be scattered on the internet) doesn't end up in a 404.

Here's where they start:

createRedirect({

I'm not sure this page ever got enough traffic to need a redirect, but it probably wouldn't hurt either 🤷‍♂

@laurieontech
Copy link
Contributor Author

Ooh good to know. I did the global search but didn't know about the redirect rule. Thanks Kyle! I'll add that.

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good catch, @gillkyle!

@AishaBlake AishaBlake merged commit d81605b into master Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the docs-routing-rename branch December 4, 2019 16:37
@muescha
Copy link
Contributor

muescha commented Dec 8, 2019

Redir for stub

should be also there a redir for the stub?

it is still in google for the exact phrase:
Google Search: Rendering Sidebar Navigation Dynamically

Issue solved

is the issue #9779 (linked from stub) now solved?

@laurieontech
Copy link
Contributor Author

We don't typically redirect stubs, but given the SEO hit here that's a point well taken. Opened #20019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants