Update Routing docs main page #19700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurieontech
added
the
type: documentation
5 tasks
gillkyle
reviewed
Nov 21, 2019
There was a problem hiding this comment.
This is awesome @laurieontech! It spells out a lot of the magic of routing really clearly.
I left a few comments for your consideration 🙂
Co-Authored-By: Sidhartha Chatterjee <[email protected]>
Co-Authored-By: Kyle Gill <[email protected]>
laurieontech
commented
Nov 22, 2019
Co-Authored-By: Kyle Gill <[email protected]>
Co-Authored-By: Kyle Gill <[email protected]>
laurieontech
commented
Nov 22, 2019
|
Awesome, thanks @gillkyle! Made some adjustments to your edits, but incorporated them all. |
… the docs and point to the content inside the main routing landing page.
gillkyle
previously approved these changes
Nov 22, 2019
Co-Authored-By: Michael <[email protected]>
laurieontech
commented
Nov 26, 2019
muescha
reviewed
Nov 26, 2019
laurieontech
commented
Nov 26, 2019
laurieontech
commented
Nov 26, 2019
marcysutton
suggested changes
Nov 27, 2019
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
marcysutton
previously approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Great job on this, @laurieontech! Approving so we can merge it in. 👍
marcysutton
approved these changes
Dec 4, 2019
|
Merging this, as I believe it's ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of addressing the 25 Learning Workflows and is part of the "Building Apps with Gatsby" improvements.
Related Issues
Addresses #18993