Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-telemetry): Allow overriding API url from ENV #16689

Merged
merged 1 commit into from
Aug 16, 2019
Merged

chore(gatsby-telemetry): Allow overriding API url from ENV #16689

merged 1 commit into from
Aug 16, 2019

Conversation

jamo
Copy link
Contributor

@jamo jamo commented Aug 16, 2019

This will make testing easier

@jamo jamo requested a review from a team as a code owner August 16, 2019 19:15
sidharthachatterjee
sidharthachatterjee approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

DSchau
DSchau approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be even nicer — but this is pretty self-explanatory.

Thanks!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 16, 2019
@sidharthachatterjee sidharthachatterjee changed the title chore(telemetry): Allow overriding API url from ENV. chore(gatsby-telemetry): Allow overriding API url from ENV Aug 16, 2019
@gatsbybot gatsbybot merged commit 4fbfd84 into master Aug 16, 2019
@sidharthachatterjee sidharthachatterjee deleted the analytics-api branch August 16, 2019 19:35
@sidharthachatterjee
Copy link
Contributor

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamo @sidharthachatterjee @DSchau @gatsbybot