Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary bodies #79

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Fix binary bodies #79

merged 3 commits into from
Sep 27, 2021

Conversation

garnaat
Copy link
Owner

@garnaat garnaat commented Sep 24, 2021

This PR includes a different approach to fix the same issue described in #70. Creating the PR so others can test to verify it fixes the issue (or not).

@adhorn
Copy link

adhorn commented Sep 27, 2021

Works like a charm for me with AppConfig.

Directory already exists
Recording
+++++ <botocore.response.StreamingBody object at 0x1057d6210>
+++++ <class 'botocore.response.StreamingBody'>
+++++ b'{ "is_enabled": "maybe", "error_code": 404, "exception_msg": "This is chaos", "rate": 0.5, "fault_type": "latency"}'
+++++ <class 'bytes'>
+++++ 2021-09-27 08:29:58.473000+00:00
+++++ <class 'datetime.datetime'>
+++++ 2021-09-27 08:29:58.473000+00:00
+++++ <class 'datetime.datetime'>

@garnaat
Copy link
Owner Author

garnaat commented Sep 27, 2021

Great! I'm going to merge and then make a new placebo release for the first time in ~ 2.5 years 8^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants