test/cpp_headers: autogenerate header test files

Rather than requiring changes to a static list of header files, use the GNU Make wildcard function to generate a .cpp file per header. This also tests whether each header includes all of the system headers for the types it uses. Change-Id: I05b82510b194533672568019e138d7d1aad2e86b Signed-off-by: Daniel Verkamp <[email protected]>
gampel · Oct 3, 2016 · d31df70 · d31df70
1 parent b827279
commit d31df70
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 40 deletions.
diff --git a/scripts/check_format.sh b/scripts/check_format.sh
@@ -11,7 +11,7 @@ if hash astyle; then
 	rm -f astyle.log
 	touch astyle.log
 	astyle --options=.astylerc "*.c" >> astyle.log
-	astyle --options=.astylerc "*.cpp" >> astyle.log
+	astyle --options=.astylerc --exclude=test/cpp_headers "*.cpp" >> astyle.log
 	astyle --options=.astylerc "*.h" >> astyle.log
 	if grep -q "^Formatted" astyle.log; then
 		echo " errors detected"

diff --git a/test/cpp_headers/.gitignore b/test/cpp_headers/.gitignore
@@ -0,0 +1 @@
+*.cpp
diff --git a/test/cpp_headers/Makefile b/test/cpp_headers/Makefile
@@ -34,11 +34,16 @@
 SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
 include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
 
-CXX_SRCS := cpp_headers.cpp
+HEADERS := $(wildcard $(SPDK_ROOT_DIR)/include/spdk/*.h)
+CXX_SRCS := $(patsubst %.h,%.cpp,$(notdir $(HEADERS)))
 
-all : cpp_headers.o
+%.cpp: $(SPDK_ROOT_DIR)/include/spdk/%.h
+	$(Q)echo "  TEST_HEADER include/spdk/$(notdir $<)"; \
+	echo '#include "spdk/$(notdir $<)"' > $@
+
+all : $(CXX_SRCS) $(OBJS)
 
 clean :
-	$(CLEAN_C)
+	$(CLEAN_C) $(CXX_SRCS)
 
 include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk
diff --git a/test/cpp_headers/cpp_headers.cpp b/test/cpp_headers/cpp_headers.cpp