Replace unrecognised unicode characters rather than raising an exception #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I agree this looks okay, and I also agree that users should be able to pass the encoding they want. Also streaming the output to get raw bytes is also an option I believe and it already works with python-on-whales: https://gabrieldemarmiesse.github.io/python-on-whales/user_guide/docker_run/#stream-the-output
|
I raised #608 to track the enhancement of allowing the user to specify encoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
Note that this still isn't ideal - if someone has a container expected to have output in an encoding other than unicode then special characters will all be replaced... It might be good to support the user passing
encodinganderrorsthrough (much likesubprocess.run()), but for now this seems like an improvement at least.