rely on getRole instead of adding hasGlobalAttr and focusable unecess…

…arily
gabalafou · Apr 30, 2024 · be633af · be633af
1 parent f914665
commit be633af
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/lib/checks/navigation/region-evaluate.js b/lib/checks/navigation/region-evaluate.js
@@ -50,7 +50,6 @@ function findRegionlessElms(virtualNode, options) {
   // - a landmark
   // - a skiplink
   // - hidden content
-  // - a presentation graphic
   if (
     getRole(virtualNode) === 'button' ||
     isRegion(virtualNode, options) ||
@@ -79,7 +78,7 @@ function findRegionlessElms(virtualNode, options) {
   } else if (
     node !== document.body &&
     dom.hasContent(node, /* noRecursion: */ true) &&
-    !isPresentational(node, virtualNode)
+    !isShallowlyHidden(virtualNode)
   ) {
     return [virtualNode];
 
@@ -92,18 +91,6 @@ function findRegionlessElms(virtualNode, options) {
   }
 }
 
-function isPresentational(node, virtualNode) {
-  return (
-    isShallowlyHidden(virtualNode) &&
-    !hasGlobalAriaAttr(virtualNode) &&
-    !dom.isFocusable(node)
-  );
-}
-
-function hasGlobalAriaAttr(virtualNode) {
-  return standards.getGlobalAriaAttrs().some(attr => virtualNode.hasAttr(attr));
-}
-
 function isShallowlyHidden(virtualNode) {
   // The element itself is not visible to screen readers, but its descendants might be
   return (