Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hacks to check the DCO in merge queues #363

Open
2 tasks
leandro-lucarella-frequenz opened this issue Apr 26, 2023 · 0 comments
Open
2 tasks

Remove hacks to check the DCO in merge queues #363

leandro-lucarella-frequenz opened this issue Apr 26, 2023 · 0 comments
Labels
part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) status:blocked Other issues must be resolved before this can be worked on type:bug Something isn't working
Milestone
post-v1.0

Comments

@leandro-lucarella-frequenz
Copy link
Contributor

leandro-lucarella-frequenz commented Apr 26, 2023 •
edited
Loading

What happened?

The DCO app doesn't support merge queues yet, so we are using a hack to cope with it (a workflow that will just mark merge_group as passing DCO.

  • Remove that workflow.
  • Configure the branch protection checks to set the origin of the DCO check again to the DCO app.

What did you expect instead?

No hacks.

Affected version(s)

No response

Affected part(s)

Build script, CI, dependencies, etc. (part:tooling)

Extra information
@leandro-lucarella-frequenz leandro-lucarella-frequenz added priority:❓ We need to figure out how soon this should be addressed status:blocked Other issues must be resolved before this can be worked on type:bug Something isn't working labels Apr 26, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this to the v1.0.0 milestone Apr 26, 2023
@keywordlabeler keywordlabeler bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Apr 26, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz removed the priority:❓ We need to figure out how soon this should be addressed label Apr 26, 2023
leandro-lucarella-frequenz pushed a commit to llucax/frequenz-sdk-python that referenced this issue Apr 27, 2023
@llucax
Add a dummy workflow to succeed DCO check on merge queues
520a542 
See frequenz-floss#363 for
more details.

Signed-off-by: Leandro Lucarella <[email protected]>
Merged
leandro-lucarella-frequenz pushed a commit to llucax/frequenz-sdk-python that referenced this issue Apr 27, 2023
@llucax
Add a dummy workflow to succeed DCO check on merge queues
41d1514 
See frequenz-floss#363 for
more details.

Signed-off-by: Leandro Lucarella <[email protected]>
leandro-lucarella-frequenz pushed a commit that referenced this issue Apr 28, 2023
@llucax
Add a dummy workflow to succeed DCO check on merge queues (#366)
d3528e9 
See #363 for
more details.
@leandro-lucarella-frequenz leandro-lucarella-frequenz changed the title Require the DCO check to pass in the branch protection Remove hacks to check the DCO in merge queues May 4, 2023
leandro-lucarella-frequenz pushed a commit to llucax/frequenz-channels-python that referenced this issue May 24, 2023
@llucax
Add a dummy workflow to succeed DCO check on merge queues
b68a1b7 
The DCO bot is not running on merge queues, so if we require the check
it will hang forever for merge queues.

See frequenz-floss/frequenz-sdk-python#363 for
more details.

Signed-off-by: Leandro Lucarella <[email protected]>
matthias-wende-frequenz pushed a commit to matthias-wende-frequenz/frequenz-sdk-python that referenced this issue Jul 6, 2023
@llucax @matthias-wende-frequenz
Add a dummy workflow to succeed DCO check on merge queues
922276b 
See frequenz-floss#363 for
more details.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax modified the milestones: v1.0.0, post-v1.0 Aug 10, 2023
stefan-brus-frequenz pushed a commit to stefan-brus-frequenz/frequenz-api-dispatch that referenced this issue Sep 7, 2023
@llucax @stefan-brus-frequenz
Add dummy DCO workflow to support merge queues
326912b 
See frequenz-floss/frequenz-sdk-python#363
for more details.

Signed-off-by: Leandro Lucarella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) status:blocked Other issues must be resolved before this can be worked on type:bug Something isn't working
Projects
Python SDK Roadmap
Status: To do
Milestone
post-v1.0
Development

No branches or pull requests
2 participants
@llucax @leandro-lucarella-frequenz