Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse WRKDIR_ARCHIVE_FORMAT for the value of PKG_FORMAT in pkgbase #825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Jan 19, 2021

pass on WRKDIR_ARCHIVE_FORMAT as PKG_FORMAT to pkgbase package builds

pass on WRKDIR_ARCHIVE_FORMAT as PKG_FORMAT to pkgbase package builds
@bdrewery
Copy link
Member

I think PKG_EXT/PKG_SUFX is more proper here and relates to #459 somewhat. The extensions are all hardcoded currently.
WRKDIR_ARCHIVE_FORMAT is for debug tarballs of work directories and not the package format.

@igalic
Copy link
Contributor Author

igalic commented Jan 19, 2021

in that case we should maybe call it PKG_FORMAT :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants