Update [email protected] and [email protected] #1134
Conversation
fel1x-developer
commented
Mar 12, 2024
•
fel1x-developer
commented
server_style is now configured in poudriere.js
RowGrouping is now disabled
|
I want to merge this but the last commit is hard to review and has unrelated changes in it. Can you either remove the last commit or split it into coherent independent commits? "Use try/catch", "Split into several files". I don't like the splitting of the file as it makes review/history hard. |
I was working on other PR which aims for splitting js files using modules, and I made a mistake to add new modules files in this review. I removed them from the last commit. |
| }); | ||
| $("#latest_url").attr("href", build_url(page_mastername, "latest")); | ||
| } else if (server_style == "inline") { |
There was a problem hiding this comment.
Why remove server_style support? It's not clear in the commits what's going on here. Restyling the file and removing logic makes it hard to review. I'm starting to think of the XZ hack with these large changes. Make them reviewable please.
See dfe3002
There was a problem hiding this comment.
server_style variable has been renamed to serverStyle following camal case convention. (most other variable names too) Right now, server_style is defined in each html file before including js scripts, but this is a bad practice since we have to edit three files to change one variable. So I defined it in the beginning of poudriere.js and renamed server_style as serverStyle
Please check line 30 of modified poudriere.js
|
I'll introduce these changes gradually |
