Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payments irrespective of party types (backport #37828) #43040

Open
wants to merge 12 commits into
base: version-14-hotfix
Choose a base branch
from

Conversation

dj12djdjs
Copy link
Collaborator

I didn't want to overwrite the changes in #38630 in case I've made an error during rebase.

continuation of: #38630
backport of: #37828

@barredterra barredterra self-requested a review September 3, 2024 23:08
@barredterra
Copy link
Collaborator

barredterra commented Sep 17, 2024

@dj12djdjs did you also consider this follow-up to the original PR? #38071

Also, these validations we're removing in the backend still exist in the frontend, even on the develop branch:

if (paid_amount > total_negative_outstanding) {
if (total_negative_outstanding == 0) {
frappe.msgprint(
__("Cannot {0} {1} {2} without any negative outstanding invoice", [
frm.doc.payment_type,
frm.doc.party_type == "Customer" ? "to" : "from",
frm.doc.party_type,
])
);
return false;
} else {
frappe.msgprint(
__("Paid Amount cannot be greater than total negative outstanding amount {0}", [
total_negative_outstanding,
])
);
return false;
}
} else {

Is this on purpose?

@dj12djdjs
Copy link
Collaborator Author

@barredterra I noticed that, my customer wasn't to picky about it and just ignored the popup.

It should be removed from the frontend. Will rebase and remove that logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants