Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python/mcap: fix statistics deserialization #846

Merged
merged 2 commits into from
Mar 9, 2023
Merged

python/mcap: fix statistics deserialization #846

merged 2 commits into from
Mar 9, 2023

Conversation

james-rms
Copy link
Collaborator

@james-rms james-rms commented Mar 8, 2023 •
edited
Loading

Public-Facing Changes

  • fixes Statistics deserialization in the python client library.

Description

  • adds a conformance test that covers the case where a channel message count differs from the overall message count.

@james-rms james-rms force-pushed the james/fg-2342-statisticsmessage_count-is-not-correct branch 2 times, most recently from 1b0fb3e to 92bc216 Compare March 8, 2023 23:27
@james-rms james-rms enabled auto-merge (squash) March 8, 2023 23:32
@james-rms james-rms disabled auto-merge March 8, 2023 23:32
@james-rms james-rms merged commit a1ea648 into main Mar 9, 2023
@james-rms james-rms deleted the james/fg-2342-statisticsmessage_count-is-not-correct branch March 9, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-rms @jtbandes