Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add help for finding compiler commit #113

Merged

Conversation

devtooligan
Copy link
Contributor

This adds some additional text and trouble shooting tips around finding the compiler-version commit argument to pass to forge verify

@devtooligan
Copy link
Contributor Author

@onbjerg can u pls help me understand more about this failing test or where I can find it?

@ZeroEkkusu
Copy link
Contributor

@onbjerg can u pls help me understand more about this failing test or where I can find it?

Ser, just add text or ignore.

```ignore
solc, the solidity compiler commandline interface
Version: 0.8.12+commit.f00d7308.Darwin.appleclang
```

@devtooligan devtooligan force-pushed the docs/add-commit-hint-for-verify branch from f99bd62 to 6a5e089 Compare March 21, 2022 01:18
@devtooligan
Copy link
Contributor Author

Thanks @ZeroEkkusu!! Do you know what causes that? Is it a linter? Or some new style guideline?

I feel like I've done a lot of code blocks in md and never been forced to enter the language before

@devtooligan devtooligan force-pushed the docs/add-commit-hint-for-verify branch from 6a5e089 to ec7062c Compare March 21, 2022 01:22
@devtooligan devtooligan force-pushed the docs/add-commit-hint-for-verify branch from ec7062c to fb313c0 Compare March 21, 2022 01:23
@mds1
Copy link
Contributor

mds1 commented Mar 21, 2022

@devtooligan
Copy link
Contributor Author

@mds1 v interesting thanks ser

@onbjerg
Copy link
Member

onbjerg commented Mar 21, 2022

Thank you for this! 😄 And yes, the lint is an mdbook-specific thing. Basically, mdbook was built for Rust projects first, so it will actually try to validate some of the codeblocks to see that they work

@onbjerg onbjerg merged commit a6cda19 into foundry-rs:master Mar 21, 2022
@onbjerg
Copy link
Member

onbjerg commented Mar 21, 2022

@all-contributors add @devtooligan for docs

@allcontributors
Copy link
Contributor

@onbjerg

I've put up a pull request to add @devtooligan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants