Remove Tabindex section from Accessibility page #6840
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all :)
I reached out via Twitter to note that on the Accessibility page there is a section that suggests the usage of tabindex="1+" to establish a tab order to a document. This is actually not such a good idea unless you really know what you are doing. @rafibomb reached back and asked if I could maybe help with this page.
I believe that entire chunk could be removed. The keyboard accessibility section leads well into how to test for keyboard accessibility as well. That is great content btw :) It is important that when exposing markup examples to the world that they are good examples. I worry young developers seeing the declaration of 1+ values on the attribute rendering their UI unusable.
Here is some further reading about this topic:
http://www.paciellogroup.com/blog/2014/08/using-the-tabindex-attribute/
Browsers and Assistive Technology work naturally with the markup order. The user can flow through the document without the assistance of tabindex if the document is marked up correctly. Skip links are the best way to allow jumps/hops for users.
I'll make another PR for a section covering CSS
outline: none;
which is a great high level topic that would fit in well with this page.Thanks for taking the time to include a special page covering accessibility! I'd love to contribute more accessibility enhancements to the framework if needed :)