Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tabindex section from Accessibility page #6840

Closed
wants to merge 1 commit into from
Closed

Remove Tabindex section from Accessibility page #6840

wants to merge 1 commit into from

Conversation

joe-watkins
Copy link

Hello all :)

I reached out via Twitter to note that on the Accessibility page there is a section that suggests the usage of tabindex="1+" to establish a tab order to a document. This is actually not such a good idea unless you really know what you are doing. @rafibomb reached back and asked if I could maybe help with this page.

I believe that entire chunk could be removed. The keyboard accessibility section leads well into how to test for keyboard accessibility as well. That is great content btw :) It is important that when exposing markup examples to the world that they are good examples. I worry young developers seeing the declaration of 1+ values on the attribute rendering their UI unusable.

Here is some further reading about this topic:
http://www.paciellogroup.com/blog/2014/08/using-the-tabindex-attribute/

Browsers and Assistive Technology work naturally with the markup order. The user can flow through the document without the assistance of tabindex if the document is marked up correctly. Skip links are the best way to allow jumps/hops for users.

I'll make another PR for a section covering CSS outline: none; which is a great high level topic that would fit in well with this page.

Thanks for taking the time to include a special page covering accessibility! I'd love to contribute more accessibility enhancements to the framework if needed :)

@rafibomb
Copy link
Member

@joe-watkins We agree with removing the tab-index details for now. I'd like to see a better explanation of the use cases for these things soon.

A PR for a section covering CSS outline: none; would be a great topic!

@rafibomb
Copy link
Member

There are merge conflicts that need to be cleared before we can merge this. Can you look at those?

@joe-watkins
Copy link
Author

@rafibomb Hmm.. I rebuilt and attempted a merge into Master locally and things look good.. try again? Ideas?

@joe-watkins
Copy link
Author

Gonna create a fresh PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants