refactor: removed manifest warnings #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
reviewed
Aug 20, 2019
There was a problem hiding this comment.
@CloudyPadmal the error must be regarding not having ACTION-VIEW in your manifest. A better way to solve this is maybe by adding:
<action android:name="android.intent.action.VIEW" />
to the default activity
CloudyPadmal
force-pushed
the
manifest-warnings
branch
from
3da7d6c
to
19b65c9
Compare
adityastic
approved these changes
Aug 20, 2019
|
🤔 there are extra builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432
Changes:
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlorcolors.xmlAPK for testing: