Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAB enabled in the app #424

Closed
wants to merge 1 commit into from
Closed

AAB enabled in the app #424

wants to merge 1 commit into from

Conversation

jddeep
Copy link
Member

@jddeep jddeep commented Aug 16, 2019 •
edited
Loading

Fixes #401

Changes: AAB enabled in the app

Screenshot/s for the changes:
N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
N/A

@jddeep jddeep added the Status: Review Required Requested reviews from peers and maintainers label Aug 16, 2019
adityastic
adityastic suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the scripts and not the bundle configuration. Use badge magic for reference

adityastic
adityastic reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CloudyPadmal Please make sure that fastlane is initialised in this repository

@jddeep jddeep requested a review from adityastic August 16, 2019 12:23
adityastic
adityastic reviewed Aug 16, 2019
View reviewed changes
scripts/upload-apk.sh Outdated Show resolved Hide resolved
adityastic
adityastic reviewed Aug 16, 2019
View reviewed changes
scripts/upload-apk.sh Outdated Show resolved Hide resolved
adityastic
adityastic reviewed Aug 16, 2019
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
adityastic
adityastic reviewed Aug 16, 2019
View reviewed changes
fastlane/Appfile Outdated Show resolved Hide resolved
CloudyPadmal
CloudyPadmal requested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll add fastlane in a later stage. Just build the appbundle for now.

@adityastic
Copy link
Contributor

@CloudyPadmal he updated the pr with the required files. That's all we need as of now

@jddeep jddeep added the In Progress Developer is working on the problem label Aug 18, 2019
@jddeep jddeep removed the In Progress Developer is working on the problem label Aug 18, 2019
CloudyPadmal
CloudyPadmal requested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only ./gradlew bundleRelease is needed in this PR and modify upload-apk.sh script to upload that file to apk branch and add it to git lfs.

scripts/upload-apk.sh Show resolved Hide resolved
app/build.gradle Show resolved Hide resolved
@CloudyPadmal CloudyPadmal added In Progress Developer is working on the problem and removed Status: Review Required Requested reviews from peers and maintainers labels Aug 19, 2019
@CloudyPadmal
Copy link
Contributor

Fixed in #428

@CloudyPadmal CloudyPadmal added invalid This is no longer relevant and removed In Progress Developer is working on the problem labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityastic adityastic adityastic requested changes

@CloudyPadmal CloudyPadmal CloudyPadmal requested changes

Assignees
No one assigned
Labels
invalid This is no longer relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build app bundles along with apks
3 participants
@jddeep @adityastic @CloudyPadmal