feat(a380x/pfd): velocity vector #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typing on Arinc429MutateFunc was incorrect, as it actually takes an Arinc429WordData as arg b, and that does not have a word member. With an Arinc429Register consumer it would work anyway. It accepted an Arinc429Word consumer though (because it implements Arinc429WordData), which silently failed to work, setting the internal register to undefined. Technically the typings are still wrong, as arg a of the mutate function is also Arinc429WordData which does not implement a set method, but practically the initialValue is fixed as an Arinc429Register which does. This whole mess could be cleaned up by getting rid of Arinc429Word so I have deprecated it here. It's whole design is very bad for CoherentGT as it requires constant allocations.
2hwk
approved these changes
Sep 22, 2024
Benjozork
approved these changes
Sep 22, 2024
|
Quality Assurance Report Discord Username : bernardor96 Testing Process: LPPT-LPPR flightTesting Results: |
tracernz
added a commit
to tracernz/a32nx
that referenced
this pull request
Sep 28, 2024
* feat(a380x/pfd): velocity vector * fix: Arinc429ConsumerSubject The typing on Arinc429MutateFunc was incorrect, as it actually takes an Arinc429WordData as arg b, and that does not have a word member. With an Arinc429Register consumer it would work anyway. It accepted an Arinc429Word consumer though (because it implements Arinc429WordData), which silently failed to work, setting the internal register to undefined. Technically the typings are still wrong, as arg a of the mutate function is also Arinc429WordData which does not implement a set method, but practically the initialValue is fixed as an Arinc429Register which does. This whole mess could be cleaned up by getting rid of Arinc429Word so I have deprecated it here. It's whole design is very bad for CoherentGT as it requires constant allocations. * fix(a380x/pfd): fpv/vv layer order * fix: start out paused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
General flight in the A32NX to ensure everything functions normally (due to Arinc429 changes).
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.