Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x): invert THS animation direction #8939

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Sep 19, 2024

Summary of Changes

Simple PR to invert the THS animation direction. Was previously increasing the angle of incidence for nose up, now it's the other way around.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Set manual pitch trim UP -> Check THS animation visually, it should go down (leading edge down)
  • Set manual pitch trim DOWN -> Check THS animation visually, it should go up (leading edge up)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@aguther aguther added A380X Related to the A380X aircraft Exp Available on experimental branch (for testing) labels Sep 24, 2024
aguther pushed a commit that referenced this pull request Sep 24, 2024
aguther pushed a commit that referenced this pull request Sep 24, 2024
@2hwk 2hwk added the QA Tier 1 label Sep 25, 2024
@2hwk
Copy link
Member

2hwk commented Sep 25, 2024

Needs testing instructions

@2hwk 2hwk added the QA A380 Only QA only for A380 required label Sep 25, 2024
aguther pushed a commit that referenced this pull request Sep 25, 2024
@crocket63
Copy link
Contributor

Testing Process:

Loaded into the 380X at LFRS
Trim up THS leading edge goes down
Trim down leading edge goes up
Testing Results:
Passed

Conclusions:
It works

aguther pushed a commit that referenced this pull request Sep 26, 2024
aguther pushed a commit that referenced this pull request Sep 28, 2024
aguther pushed a commit that referenced this pull request Sep 30, 2024
@lukecologne lukecologne enabled auto-merge (squash) October 1, 2024 16:44
@lukecologne lukecologne merged commit fe604df into flybywiresim:master Oct 1, 2024
7 checks passed
@lukecologne lukecologne deleted the ths-anim-fix branch October 1, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft Exp Available on experimental branch (for testing) QA A380 Only QA only for A380 required QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants