Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a380x): Various fixes pt.2: MFD, pitch trim switch, EFIS sync for LS button #8926

Merged
merged 15 commits into from
Sep 18, 2024
Merged

fix(a380x): Various fixes pt.2: MFD, pitch trim switch, EFIS sync for LS button #8926

merged 15 commits into from
Sep 18, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Sep 15, 2024 •
edited
Loading

Fixes #8905
Fixes #8915
Fixes #8880
Fixes #8906

Summary of Changes

  • Check for valid XPDR code in MFD/SURV/CONTROLS page (don't allow 8 or 9)
  • MFD/POSITION/NAVAIDS: Allow input of LS back course, throws format error until B/C approaches are implemented in the A380X
  • Systems-Host: Enable linting, no functional changes (ignore for review)
  • MFD: Fix navaid deselection
  • Add cockpit PITCH TRIM switch
  • Fix flickering LS scale when enabling EFIS sync in EFB

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

A380X only:
Please verify that the above four issues have been resolved:

  1. Open SD FCTL page, move cockpit PITCH TRIM switches, verify that elevator trim moves
  2. Open FMS/POSITION/NAVAIDS, de-select Navaids and verify it works via the ND
  3. Open FMS/POSITION/NAVAIDS, tune VOR with duplicate identifier (e.g. FRA), verify that de-duplication window (DUPLICATE NAMES or sth) opens
  4. Enable EFIS sync via EFB settings -> Realism, enable LS button on CAPT EFIS CP, verify LS also shows on F/O side

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@flogross89 flogross89 added Showstopper this issue is blocking the next stable release A380X Related to the A380X aircraft QA A380 Only QA only for A380 required labels Sep 15, 2024
@flogross89
remove debug messages
61bdd1d
@flogross89
Revert "systems-host: enable lint (no functional changes)"
3532c02 
This reverts commit bc1258d.
@flogross89
Merge branch 'master' into fix-a380x-various2
b765815 
# Conflicts:
#	fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/A380_COCKPIT.xml
#	fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/POSITION/MfdFmsPositionNavaids.tsx
@Letreivchen
Copy link

Quality Assurance Tester Report

Discord Username : Letreiv
Object of testing : #8926
Aircraft : A32NX/A380X
Tier of Testing : 1
Date : 17/09/2024

Testing Process:

  • Open SD FCTL page, move cockpit PITCH TRIM switches, verify that elevator trim moves --OK

  • Open FMS/POSITION/NAVAIDS, de-select Navaids and verify it works via the ND: Loaded in at EDHI, HAM VOR tuned automatically. Then added HAM on the deselect list, HAM was removed from the ND. Manually tuned CDA, added to deselect list, not removed from ND

  • Open FMS/POSITION/NAVAIDS, tune VOR with duplicate identifier (e.g. FRA), verify that de-duplication window (DUPLICATE NAMES opens --OK

  • Enable EFIS sync via EFB settings -> Realism, enable LS button on CAPT EFIS CP, verify LS also shows on F/O side --OK

Testing Results:
Passed

Negatives:

none

Conclusions:

Manually tuned navaids are not removed from the ND after added on the deselect list, accurate behavior according to current standpoint

@flogross89 flogross89 enabled auto-merge (squash) September 18, 2024 19:14
@flogross89 flogross89 merged commit 99f96a9 into flybywiresim:master Sep 18, 2024
7 checks passed
flogross89 added a commit that referenced this pull request Sep 18, 2024
@flogross89 @tracernz
fix(a380x): Various fixes pt.2: MFD, pitch trim switch, EFIS sync for…
8d0be70 
… LS button (#8926)

* check for valid xpdr code in MFD SURV

* fix ILS back course on POSITION/NAVAID

* systems-host: enable lint (no functional changes)

* disable back course

* fix deselect navaid

* add PITCH TRIM switch

* fix LS EFIS sync

* remove debug messages

* Revert "systems-host: enable lint (no functional changes)"

This reverts commit bc1258d.

* Update fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/POSITION/MfdFmsPositionNavaids.tsx

Co-authored-by: Michael Corcoran <[email protected]>

* don't use min/max for squawk code

* pass only positive courses to MMR

---------

Co-authored-by: Michael Corcoran <[email protected]>
flogross89 added a commit that referenced this pull request Sep 19, 2024
@flogross89 @BravoMike99
@sai-barath @mjuhe @lukecologne @crocket63 @tracernz
feat(a380x): Basic ECAM functionality with PseudoFWC v2 (#8750)
2f658a3 
* add PseudoFWC from a32nx

* use a32nx fwc for ECAM

* a380x adaptions

* start division

* enable formatting

* abnormal procedures interface version 1

* format version 2

* update for ATA 22&23

* add ATA 22 ABN

* ATA 23 ABN proc items

* update PseudoFWC, add TO/LDG memos

* add PFD memos

* [ECAM] PFD MEMO fix

(cherry picked from commit 99bec8c)

* XML buttons update

* remove right side failures

* lint

* prep to split between MEMOs and alerts

* update FMS switching XML, sounds

* update FWC: Connect FMS & RMP failures, introduce structure for abnormal sensed procedures

* fix master warnings/cautions

* add INFOs, some more ECAM condition check preparation (INOP SYS, INFO)

* add STS page with INFO and INOP SYS

* ATA 34 MEMOs, some ABNs

* chore(a380x): Update Memos of ATA 24, 29 & 32 to reflect A380 (#8741)

* Update ATA32 ECAM memos

* remove BRK FAN & Ata32 ecam abnormals

* add hydraulc & elec memos

* Update missing / in Nose wheel steering messages

* update ids with new convention

* add ATA 24 abnormals

* add missing items & inop systems of ATA 24 abnormals

* add hyd 29 ecam abnormals

* finish ATA 29 abnormal items

* hookup logic of elec, hyd & brakes memos

* update N/W steer disc id on pfd memo

* rebase conflicts minor fix

* chore(a380x): add 380 ECAM memos for ATA 27, 28, 31, 33, and 70, and add remaining abnormal sensed procedures (#8749)

* Add 380 ECAM memos for ATA 27, 28, 31, 33, and 70

* Add ATA 21 abnormal sensed procedures

* fix spacing

* Add all remaining ATA 21 ECAM alerts (TODO: checklist items)

* Start adding ATA 27 abnormal procedures

* Add flap/slat ecam alerts

* Add fuel ecam alerts

* Fix fuel ecam alerts and add an ATA 33 alert

* Add ATA 31 abn proc

* Add engine abn proc's

* Start adding some checklist items

---------

Co-authored-by: Florian Gross <[email protected]>

* split up ABN into multiple files

* clean up

* fix NO MOBILE sign

* add T.O config cautions/warnings

* debug line on EWD for abnormals

* TO config fixes

* overspeed warnings

* add third RA; add RA faults

* change ATA 32 inop sys

* chore(a380x): add ATA 32 abnormal sensed items (#8779)

add ata 32 sensed abnormals & inop sys

Co-authored-by: flogross89 <[email protected]>

* ATA 34: ADR faults, EXTREME LATITUDE

* add LIMITATIONS to PseudoFWC, PFD and SD

* rename LIMITATIONS SimVars

* fix(gpws/ewd): A380x Flap 3 selection check (#8796)

fix too low flaps & ecam ldg flap with config 3

* update sounds, introduce indexed simvars

* move FWS to own directory

* add IR FAULT, IR IN ALIGN (excess motion)

* only unique keys for INFO, INOP SYS, LIMITATION

* add normal procedures / ECL definitions

* refactor PseudoFWC into multiple files

* move EcamMessages

* re-introduce abnormal debug line at bottom of WD

* update N1 more often in EWD

* add C/L button to FWS

* change attribute 'color' to 'style', and change to enum

* ECL, first version

* ECL navigation

* chore(a380): add a380 fire protection ECAM messages ATA26 (#8772)

* chore: fire detection abnormals

* feat: pseudofwc logic for fire abnormals

* feat: add limitations

* feat: cargo abnormals pt1

* feat: smoke abnormals pt2

* feat: smoke limitations

* feat: smoke info

* fix: merge conflicts and bring back pseudofwc logic

* fix: review comments

* ECL progress

* fix some errors

* finish ECL, first iteration

* chore(a380): Add surveillance memos (#8775)

* add surv memos

* add surv memos logic

* update alt reporting off memo logic

* update with new structure

* fix chopped off MEMOs and LIMITATIONs

* fix EGT gauge amber marker

* MEMOs for ATA chapters 35, 46

* ECL: remove colon for some items

* ABN sensed procedures iteration 1

* refactor checklists, reduce boilerplate

* update ECL

* abnormals improvement

* update font: checked boxes, underscore, quote single/double

* use new font, fix ECAM CP

* FMS/FUEL&LOAD fix FOB visibility

* FMS: use placeholder from font

* use LGCIU for gear downlocked

* add anti ice MEMOs

* update refueling memo

* chore(a380x): Finish adding checklist items and pseudoFWC logic for ATA 21, 27, 28, 31, 33, and 70 abnormal procedures (#8773)

* Add abnormal checklist for pack 1+2 fault

* Add some more abn proc's

* Add all abn proc's for ventilation

* Start adding cond abn items

* finish last of ATA 21 abn proc's

* feat(a380/fws): A380 flight phases (#8875)

* change flightphase check to enum, check for 4 engines running

* update eng takeoff power conditions

* fix formatting

* fix takeoff power setting condition

* hookup RA3, add extra phases to enum

* rename vars and add new phases

* use 3 RA for ldg memo

* change ecam conditions with new flight phases

* fix V1 speed check

* update takeoff memo & ldg memo flight phases

* disable autobrake off memo, fix phase 4 & 5 being active

* update fws phase where used in EWD

* update checklists flight phases

* update phases in fly by wire interface, toconf check & missing fws core

* fix ECAM TO abnormals after ENG start

* modify sounds for master warn/caution

* AUTO SD page

* feat(A380): HYD sensed ecam procedures (#8801)

* hook up G, Y & G+Y SYS LO PRESS

* hookup PMP A+B OFF & missing items in G+Y LO PRESS

* fix rebase conflicts

* add sys ovht, rsvr level lo & low air pressure ecams

* add engine pump vars

* hookup vars of pump lo pressure

* improve logic of pump fault signal

* use section pressure switch vars instead of hydraulic pressure

* fix wrong engine running conditions check

* fix vars not being properly read

* fix conflicts

* add eng pump faults, fix pmp A + B off logic

* inhibit Y PMP A + B off message if RSV lo pressure

* fix var names & add identiation in RSV LO AIR PRESS

* add ELEC HYD PMP fault messages

* fix elec pmp simvars, add confirmation timer to low press signal

* add power source checks to elec pump fault

* fix var typos in fws logic & wrong data type in ecam limitations

* md lint

* chore: add NOMINMAX to fbw, revert clang-format change for fbw (#8925)

* feat(a380/mfd): add automatic perf page switching depending on fms phase (#8907)

* feat(mfd): add automatic perf switching based on phase

* only change active perf page when the phase is the same as the selected page

* fix(BTV): Fix crash when BTV exit after runway end (#8874)

Fix crash when exit is beyond 300m before runway end

* fix(a380x): Various fixes pt.2: MFD, pitch trim switch, EFIS sync for LS button (#8926)

* check for valid xpdr code in MFD SURV

* fix ILS back course on POSITION/NAVAID

* systems-host: enable lint (no functional changes)

* disable back course

* fix deselect navaid

* add PITCH TRIM switch

* fix LS EFIS sync

* remove debug messages

* Revert "systems-host: enable lint (no functional changes)"

This reverts commit bc1258d.

* Update fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/POSITION/MfdFmsPositionNavaids.tsx

Co-authored-by: Michael Corcoran <[email protected]>

* don't use min/max for squawk code

* pass only positive courses to MMR

---------

Co-authored-by: Michael Corcoran <[email protected]>

* fix link

* INOP sys update

---------

Co-authored-by: BravoMike99 <[email protected]>
Co-authored-by: Sai Sudarshan Barath <[email protected]>
Co-authored-by: Miquel Juhe <[email protected]>
Co-authored-by: lukecologne <[email protected]>
Co-authored-by: Croc <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracernz tracernz tracernz approved these changes

Assignees
No one assigned
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed Showstopper this issue is blocking the next stable release
Projects
Quality Assurance
Status: ✔️ Done
Milestone
No milestone
3 participants
@flogross89 @Letreivchen @tracernz