-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adirs): fix ADIRS low speed warning discrete logic #8892
fix(adirs): fix ADIRS low speed warning discrete logic #8892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta update the tests, and remove some unused code, otherwise LGTM.
Tests and dead code are fixed |
54c8f3a
to
e79c74e
Compare
Quality Assurance Tester/Trainee Report Discord Username : PilotEyesA350 Testing Process:
Testing Results: Negatives: Conclusions: Media: |
e79c74e
to
4386c10
Compare
…8892) * fix(adirs): fix ADIRS low speed warning discrete logic * fix(adirs): fix tests * fix(adirs): remove dead code * refactor(adirs): use one if block for discretes
Summary of Changes
This PR updates the ADR low speed warning discretes with the correct logic when unpowered or invalid, and also inverts the discrete 4. It also updates the usages of discrete 4 accordingly.
The logic is as follows (false is open circuit, true is ground):
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Currently the only usage of the discretes on the A32NX is for the L/G safety valve. The rest of the discretes are only used in the A380X.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.