Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adirs): fix ADIRS low speed warning discrete logic #8892

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Sep 10, 2024

Summary of Changes

This PR updates the ADR low speed warning discretes with the correct logic when unpowered or invalid, and also inverts the discrete 4. It also updates the usages of discrete 4 accordingly.

The logic is as follows (false is open circuit, true is ground):

  • Discretes 1-3 are false when at low speed, and true when at high speed, while 4 is inverted.
  • All discretes are false when the ADR is unpowered (represented by the IR selected knob being OFF)
  • Discretes 1-3 remain in their previous state when the CAS is invalid but the ADR is powered (represented by the ADR p/b being off), while 4 is false in this case.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Currently the only usage of the discretes on the A32NX is for the L/G safety valve. The rest of the discretes are only used in the A380X.

  • Confirm that the gear retraction/extension works correctly (and doesn't work correctly above the safety valve speed of 260kts)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta update the tests, and remove some unused code, otherwise LGTM.

@lukecologne
Copy link
Member Author

Tests and dead code are fixed

@pilotseyea350
Copy link

pilotseyea350 commented Sep 19, 2024

Quality Assurance Tester/Trainee Report

Discord Username : PilotEyesA350
Object of testing : #8892
Aircraft : A32NX
Tier of Testing : 1
Date : 18/09/2024

Testing Process:

  1. Spawn at EDDF RWY07C
  2. Takeoff and fly RWY TRK
  3. Accelerate to 190kts
  4. Retract L/G
  5. Extend L/G
  6. Turn Right TRK246
  7. Retract L/G
  8. Extend L/G
  9. Retract L/G
  10. Accelerate to 270 IAS
  11. Extend L/G
  12. Observe L/G not extending
  13. Use Gravity Extension Lever to extend L/G
  14. Observe L/G Extended
  15. Reset Gravity L/G extension
  16. Try to Retract L/G
  17. Observe L/G not retracting
  18. Reduce to 240 IAS
  19. Retract L/G

Testing Results:
Passed

Negatives:
N/A

Conclusions:
N/A

Media:
N/A

@lukecologne lukecologne enabled auto-merge (squash) September 19, 2024 10:55
@lukecologne lukecologne merged commit c8c6b9f into flybywiresim:master Sep 19, 2024
7 checks passed
@lukecologne lukecologne deleted the adirs-discrete-fixes branch September 19, 2024 11:09
tracernz pushed a commit to tracernz/a32nx that referenced this pull request Sep 28, 2024
…8892)

* fix(adirs): fix ADIRS low speed warning discrete logic

* fix(adirs): fix tests

* fix(adirs): remove dead code

* refactor(adirs): use one if block for discretes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants