Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(efb): display local charts when selected through pinned charts menu #8757

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

yourcptainspeaking
Copy link
Contributor

@yourcptainspeaking yourcptainspeaking commented Jul 15, 2024

Fixes #8710

Summary of Changes

Changes the pinned charts logic to use chartName as an alternative value for chartLinks when no links exist on the pinnedChart object due to local files not using chartLinks.

Screenshots (if necessary)

N/A

References

N/A

Additional context

Previously, the chart would not be displayed and instead the "chart" alt text would be shown until the user clicked the chart in the "Local Files" tab.

Discord username (if different from GitHub):

Testing instructions

  1. Add a PDF file to the flybywire-externaltools-simbridge\resources\pdfs folder
  2. Load into MSFS and pin this file through the "Local Files" menu
  3. Open the chart through the "Pinned Charts" menu
  4. Chart should open as expected

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

* use chartName as a backup for pinnedChart.chartLinks if no chartLinks exist (e.g. local charts)
@Saschl
Copy link
Contributor

Saschl commented Jul 16, 2024

Thanks for the contribution! LGTM

@LunakisDev
Copy link

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #8757
Tier of Testing: 1
Date: 16/7/2024

Testing Process:

  1. Added PDFs files in flybywire-externaltools-simbridge\resources\pdfs folder.
  2. Loaded into MSFS and pinned the PDFs through the "Local Files" menu.
  3. Opened the charts through the "Pinned Charts" menu.
  4. Charts open as expected.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Saschl Saschl enabled auto-merge (squash) July 19, 2024 10:38
@Saschl Saschl disabled auto-merge July 19, 2024 10:38
@Saschl Saschl enabled auto-merge (squash) July 19, 2024 10:39
@Saschl Saschl disabled auto-merge July 19, 2024 10:39
@Saschl Saschl enabled auto-merge (squash) July 19, 2024 10:39
@Saschl Saschl merged commit 608881a into flybywiresim:master Jul 19, 2024
7 checks passed
@2hwk 2hwk added this to the v0.12.0 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

EFB: Pdf-Files not showing when selected in the "Pinned Charts" tab
4 participants