fix(fwc): NW STRG DISC color fix

[Adoggman]

Fixes #8743

Summary of Changes

Changes when the ECAM memo NW STRG DISC turns amber to be in line with the real aircraft (~30 seconds after an engine has fully started).

Screenshots (if necessary)

NW STRG DISC should be green until 30 seconds after you start the first engine, when it should turn amber. After shutting down both engines, it will turn green again.

References

https://youtu.be/YouKucin6fs?t=75

Additional context

Discord username (if different from GitHub):
adoggman

Testing instructions

NW STRG DISC shows up in the ECAM during pushback. You can get it to activate by using the EFT or GSX.
This does not change when the message shows up, but when it changes from green to amber in color.
Previously, it would turn amber as soon as either engine starts were flipped on.
Now, it should turn amber about 30 seconds after the first engine has been fully started.

Using your favorite pushback tool, test that the NW STRG DISC message shows on the ECAM when expected and appears green until 30 seconds after an engine has fully started. Test both starting with engine 1 first and engine 2 first.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

[BravoMike99]

The real FWC checks if either engine is running to change the color of the nose wheel steering message (just like the current logic) to amber. You can probably fix the issue by changing the engine state condition without needing to make it dependent on the flight phase, as the engine is considered as fully running when the state is 0 if I'm not mistaken.

[Adoggman]

The real FWC checks if either engine is running

The video referenced does not show it working that way, it only turns amber after BOTH engines have (at least partially) started. Is there a better/more technical reference?

the engine is considered as fully running when the state is 0 if I'm not mistaken.

If you're talking about A32NX_ENGINE_STATE:

OFF | 0
ON | 1
STARTING | 2
SHUTTING | 3

We could do something like [1, 2].includes(this.engine1State.get()) && [1, 2].includes(this.engine2State.get()) ? 1 : 0 to make it more closely match the current logic, but it still doesn't behave quite like in the video as it turns amber the moment the second engine is started and doesn't have a short delay like in the video.

[lukecologne]

I can't give you a reference, but it is engine1running || engine2running, but for at least 30s. That is why you observed the delay.
More precisely, running is defined here as N2 greater than some idle threshold. You can look around the rest of the pFWC code, I'm told this or a similar condition is already used multiple times for other warnings

[lukecologne]

Ah, take a look at engine1CoreAtOrAboveMinIdle and engine2CoreAtOrAboveMinIdle. These are the variables you want, you just need to add a confirm time of 30s to it.

[Adoggman]

Do you know of any places I can see that are using a timed delay as an example? It seems like adding tracking for how long the engines have been running would make this fix significantly more complicated.

[lukecologne]

Take at a look at the NXLogicConfirmNode that is used in the pFWC

[Adoggman]

I changed it to use NXLogicConfirmNode (30 seconds) and engine state.

[2hwk]

@lukecologne to approve as well

[LunakisDev]

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #8747
Tier of Testing: 1
Date: 17/7/2024

Testing Process:
Using EFB pushback

1. Spawned at LCLK .
2. Started the A/C.
3. Pushback (Verified that "NW STRG DISC" shows up in the ECAM during pushback).
4. Verified that "NW STRG DISC" turns amber about 30 seconds after the first engine has been fully started.
5. Tested both starting with engine 1 first and engine 2 first.

I also did the same test with GSX pushback. (Everything works as expected)

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM