Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pfd): (a32nx, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8733

Merged
merged 53 commits into from
Jul 8, 2024

Conversation

flogross89
Copy link
Contributor

Summary of Changes

Relevant for A32NX only.

  • Adds OANS, ROP and ROW warnings to the PFD and aural alerts
  • Transmits new EGPWS discrete words from the GPWS module
  • Implements stall warning (aural alert and PFD warning)

Screenshots (if necessary)

image
image
image
image
image
image
image
image
image
image

References

https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Acceptance criteria: 1x Tier 1 test with all test cases passed, 2x Tier 2 tests passed
Testing of functional ROW/ROP on A32NX not yet possible.

For A32NX:
Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.

Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:

  • Sinkrate
  • Pull Up
  • Terrain
  • Don't Sink
  • Too Low Gear
  • Too Low Flaps
  • Too Low Terrain
  • Glideslope

Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000

Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route

Test 5:
Spawn A32NX on runway, speed tape should not exhibit red markers indicating missing/erroneous data

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

flogross89 and others added 30 commits April 29, 2024 00:36
A32NX: Add GPWS discrete word to GPWS,
Both: warnings position update
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx
#	fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
@pdellaert
Copy link

pdellaert commented Jul 6, 2024

Not an official QA member, so this is an adhoc report as I was one who encountered significant issues with this PR that were addressed with commit f555b15 . Before this commit, the behavior was that the flight plan was not showing distances, ND would not show the flight plan, or if it did, it was extremely slow in updating, FCU HDG/SPD never went to --- and T.O Config would always show an error that speeds were not entered/properly set. In flight, it would never want to enter NAV mode, DIR TO did not work.

From the investigation, it was determined that a caught, but undocumented/not-logged error (likely caused by a race condition in loading variables) caused a significant straining continuous loop in the systems that caused everything else to slow down or stop working (I am not smart enough to explain the full details).

Discord : straks
Object of testing: 8733
Tier of Testing : 🎉 -tier
Date : 2024-07-04

Covers:

Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route

Impactful addons:

  • Navigraph navdata

Process:

Set up Simbrief flight:

Generated at: 04.07.2024, 23:35:58
AirFrame: FBW A32NX 337364_1631550522735 (provided by FBW)
AIRAC Cycle: 2406
Origin: KOAK
Destination: KRNO
Route: OAK6 OAK DCT ORRCA ORRCA1
  1. Cold & Dark at a gate
  2. Follow SOP to start up aircraft
  3. Load flightplan from simbrief in EFB and MCDU (INIT Page)
  • Verify ND shows flight plan immediately
  1. Configuring departure/SID
  • Verify ND shows temporary flight plan immediately
  1. Configuring Arrival/STAR & Approach
  • Verify ND shows temporary flight plan immediately
  1. Verify in the flight plan distances are shown
  2. Verify HDG is set to --- on FCU
  3. Fill in FUEL PRED on MCDU
  4. Fill in TAKEOFF PERF page with proper speeds
  • Verify SPD is set to --- on FCU
  1. Continue follow SOP for setting up aircraft
  2. Push and start from gate (GSX)
  3. Taxi to runway
  4. Test T.O. CONFIG on ECAM
  • Verify no SPEED errors
  1. Take off
  2. Verify DIR TO functionality as part of the SID
  3. Climb
  • Verify FPLN & ND Shows (T/C)
  • Verify FPLN & ND Shows (T/D)
  • Verify FPLN shows VNAV information (target altitudes)
  1. Cruize
  • Verify FPLN & ND Shows (T/D)
  • Verify FPLN shows VNAV information (target altitudes)
  1. Descent
  • Verify FPLN shows VNAV information (target altitudes)
  • Verify VNAV details and follows planned descent
  • Verify VNAV information get updated as necessary
  1. Approach/Landing
  • Verify GO-Around procedure in FPLN & shown on ND
  • Verify ILS approach
  • Verify callouts
  • Verify autobrake, reversers, flare, ....
  1. Taxi to gate
  2. SOP shutdown

Result:
From my experience, it behaved exactly as expected from a regular flight perspective in the A32NX, all observed issues from before the f555b15 commit did not occur and everything worked as expected and very efficiently.

@Saschl
Copy link
Contributor

Saschl commented Jul 8, 2024

Quality Assurance Report

Discord: Saschl
Object of testing: #8733
Tier of Testing: 2

Third try:

Testing Process:

Full flight LGKR - LOWW

Performed the flight and especially observed flight plan updates and ND. Flightplan updated immediately and smoothly as before.

Observed console for errors after adding the additional error logging, none could be observed. Issue seems to be resolved finally

Negatives:
N/A

Testing Results:
Passed

Conclusions:
No regressions found.

@flogross89 flogross89 merged commit de2903c into flybywiresim:master Jul 8, 2024
7 checks passed
@flogross89 flogross89 deleted the fix-a380x-pfd-vdev branch July 27, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants