-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pfd): (a32nx, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8733
feat(pfd): (a32nx, third try): Add vertical deviation indicator, ROW/ROP/OANS warnings v3 #8733
Conversation
A32NX: Add GPWS discrete word to GPWS, Both: warnings position update
…ize before and after decimal point
…t gauge and PFD tapes
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx # fbw-a380x/src/systems/instruments/src/PFD/LandingSystemIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx # fbw-a380x/src/systems/instruments/src/PFD/SpeedIndicator.tsx # fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/systems-host/systems/LegacyGpws.ts # fbw-common/src/systems/shared/src/Arinc429RegisterSubject.ts
# Conflicts: # .github/CHANGELOG.md
Not an official QA member, so this is an adhoc report as I was one who encountered significant issues with this PR that were addressed with commit f555b15 . Before this commit, the behavior was that the flight plan was not showing distances, ND would not show the flight plan, or if it did, it was extremely slow in updating, FCU HDG/SPD never went to From the investigation, it was determined that a caught, but undocumented/not-logged error (likely caused by a race condition in loading variables) caused a significant straining continuous loop in the systems that caused everything else to slow down or stop working (I am not smart enough to explain the full details). Discord : straks Covers:
Impactful addons:
Process: Set up Simbrief flight:
Result: |
Quality Assurance Report Discord: Saschl Third try: Testing Process: Full flight LGKR - LOWW Performed the flight and especially observed flight plan updates and ND. Flightplan updated immediately and smoothly as before. Observed console for errors after adding the additional error logging, none could be observed. Issue seems to be resolved finally Negatives: Testing Results: Conclusions: |
Summary of Changes
Relevant for A32NX only.
Screenshots (if necessary)
References
https://www.youtube.com/watch?v=EorNGwNTzwQ
https://www.navblue.aero/product/rops-plus/
https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/the-runway-overrun-prevention-system.pdf
https://www.youtube.com/watch?v=FbCIjWaMqTI
https://www.youtube.com/watch?v=hDh_9MEz-hg
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
Acceptance criteria: 1x Tier 1 test with all test cases passed, 2x Tier 2 tests passed
Testing of functional ROW/ROP on A32NX not yet possible.
For A32NX:
Test 1: Stall warning
Bring aircraft into alternate law (e.g. by turning both SECs to OFF), throttle to idle and maximum pitch up, until the aircraft enters a stall.
An aural warning "STALL, STALL", shall be heard.
Test 2: GPWS warnings
Please perform a flight triggering the following GPWS warnings, and confirm that there has been no regression, i.e. they still trigger:
Test 3: ROP/ROW Warnings in A32NX
To trigger these manually, set the local variable A32NX_ROW_ROP_WORD_1 to the following value:
MAX BRAKING: 14046724096.000
MAX REVERSE: 14053015552.000
IF WET: RWY TOO SHORT: 14060355584.000
RWY TOO SHORT: 14068219904.000
Test 4:
Prepare FMS with departure runway + SID
After T/O, NAV should engage after SRS, FD and AP should follow programmed route
Test 5:
Spawn A32NX on runway, speed tape should not exhibit red markers indicating missing/erroneous data
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.