-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a32nx): takeoff performance calculator #8678
Merged
tracernz
merged 46 commits into
flybywiresim:master
from
tracernz:mrc-to-perf-post-lint
Jun 28, 2024
Merged
feat(a32nx): takeoff performance calculator #8678
tracernz
merged 46 commits into
flybywiresim:master
from
tracernz:mrc-to-perf-post-lint
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
force-pushed
the
mrc-to-perf-post-lint
branch
from
June 15, 2024 13:06
f9dead1
to
5fa5722
Compare
2hwk
reviewed
Jun 15, 2024
2hwk
previously requested changes
Jun 15, 2024
Saschl
approved these changes
Jun 25, 2024
tracernz
force-pushed
the
mrc-to-perf-post-lint
branch
from
June 27, 2024 08:22
721fe66
to
2516838
Compare
tracernz
force-pushed
the
mrc-to-perf-post-lint
branch
from
June 27, 2024 08:37
2516838
to
b4c0e71
Compare
Non-QA Team Report (asked by @tracernz) Discord: xmudrii Testing Process:
Negatives:
Testing Results: Conclusions: |
This was referenced Jun 28, 2024
QA Report Discord: alepouna Testing Process:
Testing Results: |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3393
Fixes #4444
Summary of Changes
Notes:
The takeoff performance model is developed and maintained by @donstim. Huge thanks. Also a big thanks to everyone who helped with development of that model.
TODO: Check out if anything needs done for localisations.
Screenshots (if necessary)
References
Additional context
The takeoff calculator is in shared rather than EFB specifically because I intend to implement takeoff performance uplink in future (#8667) and it may also be useful/extended for TOS2. Note that TO perf uplink in the FMS does not uplink a single perf result (e.g. from the EFB), but rather a series of results for the selected runways and the intent is to implement like that as in the real thing.
Discord username (if different from GitHub):
Testing instructions
Test the general usability and buginess, and any questionable results. The takeoff model has been validated on a wide range of scenarios so it's mostly about the UI and interactions, and rejecting invalid cases.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.