-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FMA): LVR CLB not showing when preselected speed becomes active #8644
Merged
2hwk
merged 7 commits into
flybywiresim:master
from
BravoMike99:fix-pfd-thrclb-speedsel
Jul 14, 2024
Merged
fix(FMA): LVR CLB not showing when preselected speed becomes active #8644
2hwk
merged 7 commits into
flybywiresim:master
from
BravoMike99:fix-pfd-thrclb-speedsel
Jul 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hwk
approved these changes
May 8, 2024
BravoMike99
force-pushed
the
fix-pfd-thrclb-speedsel
branch
from
May 20, 2024 20:52
16b9b75
to
17a6bac
Compare
Quality Assurance Trainee Report Discord: LunakisLeaks Testing Process:
Negatives: Testing Results: Conclusions: |
BravoMike99
force-pushed
the
fix-pfd-thrclb-speedsel
branch
3 times, most recently
from
June 17, 2024 23:18
fc6be9e
to
78a6155
Compare
BravoMike99
force-pushed
the
fix-pfd-thrclb-speedsel
branch
from
June 25, 2024 22:56
78a6155
to
9459470
Compare
Quality Assurance Trainee Report Discord: 2cas Testing Process:
Negatives: Testing Results: Conclusions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Hides "SPEED SEL" & "MACH SEL" FMA if autobrake max is selected.
Fixes possibility of ATHR messages being cleared on the FMA when preselected speed becomes active.
Screenshots (if necessary)
References
Video showing speed sel only appearing after autobrake max disarmed is now private sadly :(
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
Arm autobrake max and verify "BRK MAX" appears on the PFD.
Set the acceleration altitude to be the same as thrust reduction on the PERF TO page and insert a preselected speed on the PERF CLB page.
Perform a takeoff and verify that the "SPEED SEL" message appears after autobrake is disarmed (L/G up)
At reduction altitude, verify that LVR CLB appears on the FMA.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.