Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FMA): LVR CLB not showing when preselected speed becomes active #8644

Merged
merged 7 commits into from
Jul 14, 2024

Conversation

BravoMike99
Copy link
Contributor

Fixes #[issue_no]

Summary of Changes

Hides "SPEED SEL" & "MACH SEL" FMA if autobrake max is selected.
Fixes possibility of ATHR messages being cleared on the FMA when preselected speed becomes active.

Screenshots (if necessary)

References

Video showing speed sel only appearing after autobrake max disarmed is now private sadly :(

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

Arm autobrake max and verify "BRK MAX" appears on the PFD.
Set the acceleration altitude to be the same as thrust reduction on the PERF TO page and insert a preselected speed on the PERF CLB page.
Perform a takeoff and verify that the "SPEED SEL" message appears after autobrake is disarmed (L/G up)
At reduction altitude, verify that LVR CLB appears on the FMA.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@LunakisDev
Copy link

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #8644
Tier of Testing: 1
Date: 22/5/2024

Testing Process:

  1. Spawned at LGAV in C&D state
  2. Started the aircraft
  3. Set the acceleration altitude to be the same as the thrust reduction
  4. Set the preselected speed
  5. Performed a takeoff and verified that the "SPEED SEL" message appears after the autobrake is disarmed
  6. Verified that "LVR CLB" appears on the FMA at the reduction altitude

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@BravoMike99 BravoMike99 force-pushed the fix-pfd-thrclb-speedsel branch 3 times, most recently from fc6be9e to 78a6155 Compare June 17, 2024 23:18
@2hwk
Copy link
Member

2hwk commented Jul 14, 2024

Quality Assurance Trainee Report

Discord: 2cas
Object of testing: #8644
Tier of Testing: 1
Date: 14/07/2024

Testing Process:

  1. Spawned at LGAV in C&D state
  2. Started the aircraft
  3. Set the acceleration altitude to be the same as the thrust reduction
  4. Set the preselected speed
  5. Performed a takeoff and verified that the "SPEED SEL" message appears after the autobrake is disarmed
  6. Verified that "LVR CLB" appears on the FMA at the reduction altitude

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@2hwk 2hwk enabled auto-merge (squash) July 14, 2024 07:52
@2hwk 2hwk merged commit d3e6e98 into flybywiresim:master Jul 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

5 participants