Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CDU): auto weight import in MCDU uses target values with gsx now #8558

Merged

Conversation

Maximilian-Reuter
Copy link
Member

Fixes #[issue_no]

Summary of Changes

This is a quick fix for the auto import of the ZFW and ZFWCG during boarding in the MCDU.
For our own boarding this function uses the target values of the boarding process.

This fix makes sure that same functionality extends to GSX boarding as well.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):_chaoz_

Testing instructions

  1. Start C/D
  2. make sure GSX payloadsync is disabled in the 3rd party EFB options.
  3. Set some random boarding values or use a Simbrief import
  4. Start boarding
  5. Set up mcdu enough to be able to import weights on the INIT B page
  6. Press the line select key next to the empty ZFW/ZFWCG entry
  7. Values that show in the scratchpad should be the target boarding values set in the EFB
  8. Repeat the entire process with GSX payload sync enabled and using GSX for boarding

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8558
Tier of Testing: 1
Date: 10/3/2024

Testing Process:

Tested with GSX

  • Start C/D
  • make sure GSX payloadsync is disabled in the 3rd party EFB options.
  • Set some random boarding values or use a Simbrief import
  • Start boarding
  • Set up mcdu enough to be able to import weights on the INIT B page
  • Press the line select key next to the empty ZFW/ZFWCG entry
  • [PASS] Values that show in the scratchpad should be the target boarding values set in the EFB
  • [PASS] Repeat the entire process with GSX payload sync enabled and using GSX for boarding

Testing Results:
Passed

@Maximilian-Reuter Maximilian-Reuter enabled auto-merge (squash) March 10, 2024 19:02
@Maximilian-Reuter Maximilian-Reuter merged commit 47dbbd8 into flybywiresim:master Mar 10, 2024
7 checks passed
@2hwk 2hwk added this to the v0.11.2 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants