Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: A32NX BatDisplay to fbw-common / add A380 separate BAT instrument #8495

Merged
merged 20 commits into from
Feb 23, 2024

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Feb 15, 2024

Summary of Changes

  • Moved the A32NX BatDisplay code to fbw-common.
  • Added a separate instrument for the A380X.
  • Added a LVAR for the display knob (animation not modeled in cockpit yet) to display one of the 4 batteries or being turned OFF.
  • Added B: events

L:A380X_KNOB_OVHD_BAT_POSITION: 0..4

Screenshots (if necessary)

2024-02-15_23h46_29.mp4

Discord username (if different from GitHub): cdr_maverick

Testing instructions

A380 only
Test if the BAT Voltage Indicator Switch and display work as expected.
It should show:
L:A32NX_ELEC_BAT_${batteryNumber}_POTENTIAL
according to this mapping:
batteryNumber = ESS=4, APU=3, OFF=00.0V, BAT1=1, BAT2=2

If you you know how you can check the assosiated LVar and B: Events

  • L:A380X_OVHD_ELEC_BAT_SELECTOR_KNOB

image

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@beheh
Copy link
Member

beheh commented Feb 15, 2024

When turning it it should read 0.00V:
A380 Voltmeter showing 0.00V

Something about the size/aspect ratio doesn't look right though, it seems like there is uniform padding around the characters whereas in our version there's a lot of padding left and right.

Also just to confirm, it seems the char-by-char update from the 320 still exists, so that can stay: https://youtu.be/GspxOmtreIQ?t=43

@frankkopp
Copy link
Member Author

frankkopp commented Feb 15, 2024

Fixed the OFF = 00.0V

CSS I will work on - trying to find a better reference

@tracernz
Copy link
Member

tracernz commented Feb 15, 2024

Something about the size/aspect ratio doesn't look right though, it seems like there is uniform padding around the characters whereas in our version there's a lot of padding left and right.

The display in the A320 model is the wrong aspect ratio and size, so the instrument is setup to match the incorrect screen and look as good as possible given that issue.

@beheh
Copy link
Member

beheh commented Feb 16, 2024

The display in the A320 model is the wrong aspect ratio and size, so the instrument is setup to match the incorrect screen and look as good as possible given that issue.

It's much better already in the video at the top of the PR right now! It originally looked like this:
image

I love it!

@frankkopp
Copy link
Member Author

this:

Yea - tweaked it a bit alredy.

Do we have real life reference - I haven't found much.
Also is this display always on independent of any power bus?

@frankkopp frankkopp force-pushed the move-bat-to-common branch 3 times, most recently from 6a8c00e to 9a8681a Compare February 17, 2024 14:23
@frankkopp frankkopp marked this pull request as ready for review February 17, 2024 17:26
@frankkopp frankkopp self-assigned this Feb 17, 2024
@frankkopp frankkopp added the Not Ready For Review Still draft but needs a GitHub build label Feb 17, 2024
@frankkopp frankkopp added Needs Code Review QA A380 Only QA only for A380 required and removed Not Ready For Review Still draft but needs a GitHub build labels Feb 18, 2024
@frankkopp frankkopp merged commit 86c3fb9 into flybywiresim:master Feb 23, 2024
7 checks passed
@frankkopp frankkopp deleted the move-bat-to-common branch February 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Code Review QA A380 Only QA only for A380 required
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants