Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(efcs): prevent uncommanded roll over 400kts #8318

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Dec 1, 2023

Summary of Changes

Fixes a small issue where the omega_0 of the roll law was going to either 0 or NaN, when exceeding 400kts CAS, due to the default setting in MATLABs interp1d function to not extrapolate (the maximum x-value of the LUT was 400kts). Now, extrapolation is active and points have been added to ensure a 0-gradient at the edges (i.e. the value remains constant below 0kts and above 400kts).

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@alepouna
Copy link
Member

alepouna commented Dec 2, 2023

QA Report

Discord: alepouna
Object of testing: #8318
Tier of Testing : 2
Date : 02/12/2023

Testing Process:

  • Replicate original issue (reported on discord) and do some other 'crazy' things to see no weird behavior.
  • Performed QA tier 2 short flight as well.

Testing Results:
Passed

@lukecologne lukecologne enabled auto-merge (squash) December 3, 2023 01:07
@lukecologne lukecologne merged commit f7229f9 into flybywiresim:master Dec 3, 2023
6 checks passed
@lukecologne lukecologne deleted the lateral-law-fix branch December 3, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants