fix(pfd): show ils frequency when loc not received #8271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tracernz it is missing the ILS course. Is that some kind of regression? |
|
None is set. It was tuned manually without a course. |
|
QA Report Discord: alepouna Testing Process:
Testing Results: |
Saschl
pushed a commit
that referenced
this pull request
Nov 2, 2023
* fix: hack around lack of tspan * fix(pfd): refactor ils info and make freq visible without loc * fix(pfd): use correct frequency simvar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8173.
Summary of Changes
Refactors the ILS info to be more idiomatic and efficient (we don't need to alter the DOM constantly for things that aren't visible), and makes the ILS frequency visible whenever it is valid, with no requirement for a signal to be received as in the refs.
Screenshots (if necessary)
References
See linked issue.
Additional context
Discord username (if different from GitHub):
Testing instructions
Try some ILS frequencies and make sure the info at the bottom left behaves properly. Make sure the frequency is always visible when tuned and LS is turned on. Fly at least one ILS approach from outside the ILS range and make sure the info appears correctly.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.