Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cond): Fixing Temp-Zone-Vars in CRZ-Page #8243

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

cptnuss-ops
Copy link
Contributor

@cptnuss-ops cptnuss-ops commented Oct 5, 2023

Fixes #8213

Summary of Changes

Changed the SimVars for aftCabinTemp and fwdCabinTemp assignment, so that the proper temperature is displayed on the CRZ-Page again.

Screenshots (if necessary)

Temperature changes in the COND Page are reflected to the CRZ Page:
image
image

References

-- NONE --

Additional context

-- NONE --

Discord username (if different from GitHub): cpt.nuss

Testing instructions

Load plane, and fly (to trigger CRZ-Page) choose different temp for each cabin zone and observe the temperature change of the section on the CRZ-Page. Verify, that changing the cockpit temperature does not effect the displayed temperature in the fwd and aft cabin!

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@cptnuss-ops cptnuss-ops changed the title Fixing Temp-Zone-Vars in CRZ-Page fix: Fixing Temp-Zone-Vars in CRZ-Page Oct 5, 2023
@cptnuss-ops cptnuss-ops changed the title fix: Fixing Temp-Zone-Vars in CRZ-Page fix(cond): Fixing Temp-Zone-Vars in CRZ-Page Oct 5, 2023
@cptnuss-ops cptnuss-ops marked this pull request as ready for review October 5, 2023 12:27
@tracernz
Copy link
Member

tracernz commented Oct 6, 2023

Could you please add a changelog line to say that you fixed this at the end of the 0.11.0 list in https://github.com/flybywiresim/aircraft/blob/master/.github/CHANGELOG.md? This is how a lot of users keep track of what's been fixed or changed each time they update.

@cptnuss-ops
Copy link
Contributor Author

@tracernz sorry, I've forgotten that. Changelog entry is written now! :)

@Saschl
Copy link
Contributor

Saschl commented Oct 13, 2023

QA Report

Discord: saschl
Tier of Testing : 1
Date : 2023/10/13

Testing Process:

Checked SD CRZ page and verified temperatures in the cabin are now different from the cockpit.

image

Testing Results:
Passed

@Saschl Saschl enabled auto-merge (squash) October 13, 2023 12:17
@Saschl Saschl merged commit ba151e1 into flybywiresim:master Oct 13, 2023
6 checks passed
@cptnuss-ops cptnuss-ops deleted the issue_8213_fix branch November 3, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

Wrong Cabin temperature on Cruise SD
3 participants