fix(ND): fix the color and orientation of course reversal arrow

[Maximilian-Reuter]

Fixes #[issue_no]

Summary of Changes

This fixes the color of the course reversal arrow so it no longer becomes magenta or amber depending on the vnav constraint prediction at the waypoint

It also fixes the orientation of the arrow since it used to follow the inbound course but no longer does in the current NDv2 implementation.

Screenshots (if necessary)

Before:

After:

References

Additional context

Discord username (if different from GitHub): _chaoz_

Testing instructions

You can force the course reversal arrow by inserting a hold at a waypoint.
You need to choose a waypoint with a vnav constraint, or add one yourself.

The prediction will only show on waypoints that are a few waypoints ahead from your current waypoint.

For the orientation, just play with different courses for the hold and the arrow should change accordingly

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[Saschl]

LGTM

[alepouna]

QA Report

Discord: alepouna
Object of testing: #8185
Tier of Testing : 1
Date : 02/09/2023

Testing Process:

• Inserting a hold at a waypoint (that has a constraint)

Testing Results:
Passed