Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): GitHub Action for QA labels #8089

Merged
merged 9 commits into from
Sep 18, 2023
Merged

feat(ci): GitHub Action for QA labels #8089

merged 9 commits into from
Sep 18, 2023

Conversation

alepouna
Copy link
Member

@alepouna alepouna commented Jun 28, 2023

Fixes #[issue_no]

Summary of Changes

Introduces a GitHub Action (created by me https://github.com/auroraisluna/qa-labels-for-prs) with the purpose of automatically labeling incoming PRs when they are marked via a QA report or by a developer as "Ready to test"

This does not change the workflow of QA, however it simply adds labels depending on the QA report.

Example:
image

For maintainers:
This action requires pull_requests write permission for the labels.
Action repo: https://github.com/auroraisluna/qa-labels-for-prs

Discord username (if different from GitHub): alepouna

Testing instructions

This does not require any aircraft change. Once this Action is enabled, any new QA comments in PRs will have labels.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@alepouna
Copy link
Member Author

I have created this repo to demonstrate how it works: https://github.com/auroraisluna/qa-labels-for-prs-test/pull/1, feel free to explore.

@alepouna alepouna changed the title feat: GitHub Action for QA labels feat(ci): GitHub Action for QA labels Jun 28, 2023
@2hwk
Copy link
Member

2hwk commented Aug 11, 2023

At least code wise looks ok, approved

@mico975
Copy link
Contributor

mico975 commented Aug 29, 2023

LGTM, merge it. Will certainly make identifying the status of each PR easier than before.

@alepouna alepouna closed this Sep 17, 2023
@alepouna alepouna deleted the patch-2 branch September 17, 2023 18:02
@alepouna
Copy link
Member Author

that was not my intention

@alepouna alepouna restored the patch-2 branch September 17, 2023 18:08
@alepouna alepouna reopened this Sep 17, 2023
@alepouna
Copy link
Member Author

Not RTT yet, fixing a potential bug.

@alepouna alepouna marked this pull request as draft September 17, 2023 18:09
@alepouna alepouna marked this pull request as ready for review September 17, 2023 18:19
@alepouna
Copy link
Member Author

GitHub uses v1.0.0 on my personal testing repo but it should use 1.0.2. If someone can test this out - RTM :)

@Saschl Saschl merged commit a18fc16 into flybywiresim:master Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants