feat(model): Add detailed rivet mesh to support ALDB+COMP+NORM ribbons #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouveng
added
Texture
bouveng
force-pushed
the
feat-rivet-mesh
branch
2 times, most recently
from
8a33934
to
329917c
Compare
ImenesFBW
approved these changes
Apr 3, 2022
ErickSharp
pushed a commit
that referenced
this pull request
Apr 21, 2022
#7002) * Add rivet mesh to model * Transparent texture for rivet mesh * Add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds a secondary detailed ribbon mesh, to allow combination of ALBD, COMP and NORM textures for ribbons.
This allows us to have more detailed ribbons.
This PR adds nothing for anyone.
It is an OPT-IN feature.
Screenshots (if necessary)
Illustration of coverage of custom ribbon mesh
Default ASOBO `NORM` based rivet
High definition rivet-ribbon, using `ALBD` + `NORM` in combination.
Additional context
This cant be tested without a custom texture, no such texture exist for fbw-livery yet.
Discord username (if different from GitHub): @bouveng
Testing instructions
No testing needed. Direct merge approved.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.