Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not crash pfd when ls frequency = 0 #6856

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Mar 5, 2022

Fixes #[issue_no]

Summary of Changes

For a short moment, NAV FREQUENCY:3 can return 0 which crashes the PFD as it tries to split that frequency for displaying. This PR adds a check that the frequency is splitted correctly and aborts further execution if it's invalid.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Enable the LS info on the PFD and enter different ILS frequencies (in range, out of range, valid and invalid combinations) and make sure the PFD stays on all the time and shows valid information.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Hyper3007
Copy link

Quality Assurance Trainee Report

Discord : [CRSD] Andrew3007#0125
Object of testing: #6856
Tier of Testing : 1
Date : 05/03/2022

Testing Process:
Spawn in at EGWU on the runway entered frequency for EGWU, then i enter freq for EGLC, EGLL, EGKK, EGSS also enter, KJFK then re entered freq for EGWU again and repeated all those frequency a second time with 0 crashes to the PFD

Negatives:
N/A

Testing Results:
Passed

Conclusions:
No mattter what frequency i entered the PFD did not crash

Media:
freq
)

@NUTTTTTTTT
Copy link
Contributor

Quality Assurance Tester Report

Discord: █▀█ █▄█ ▀█▀#2123
Object of testing: #PR 6856
Tier of Testing: 1
Date: 05/03/2022

Testing Process:

  • Loaded at runway at EGKK.
  • Tested local ILS, distance to navaid shown, LOC and GS diamonds shown as expected. - PASS
  • Tested various other ILS frequencies, random number combinations, out of range frequencies et, tested for any PFD crashes - PASS.

Negatives: N/A

Testing Results: PASS.

Conclusions: No crashes to PFD. LGTM!

Media:
image

@FlightSimmer7700
Copy link
Contributor

Quality Assurance Tester

Discord: FlightSimmer7700#5438
Object of testing: #6856
Tier of Testing: 1
Date: 5/3/22

Testing Process: Loaded C&D at LGAV and entered 110.5 (ils freq for LGAV) which worked and then entered 109.5 (not close) and checked captain's pfd didn't crash.
(Have also tested on dev to make sure that the same method did crash the pfd previously)
Negatives: N/A
Testing Results: Passed

Conclusions: Works as intended with no blank pfds!

@Saschl Saschl merged commit bf05cc8 into flybywiresim:master Mar 5, 2022
Benjozork pushed a commit that referenced this pull request Mar 6, 2022
frankkopp pushed a commit to frankkopp/aircraft that referenced this pull request Mar 13, 2022
@2hwk 2hwk added this to the v0.8.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants