Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: engine shutdown and start-up/ shutdown animation #6284

Merged
merged 15 commits into from
Dec 15, 2021

Conversation

Taz5150
Copy link
Contributor

@Taz5150 Taz5150 commented Nov 30, 2021

Fixes #3169
Fixes #5119
Fixes #6301

Summary of Changes

This is a dual PR:
(i) Implements realistic engine shutdown, taking into account primary parameter behavior, including realistic EGT cooldown, and engine delay between master off and spool-down (around 1.2 seconds)

(ii) Realistic engine animation behavior at start-up and shutdown. Animation is now attached to the FBW N1 LVar, with fan starting right at the beginning of the process (not after ignition).

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): TazX [Z+2]#405

Testing instructions

(1) Testing for Engine Shutdown:

  • Start aircraft on the runway
  • Shut one of the engines
  • Engine spool-down should start between 1 and 2 seconds afterwards
  • N1, N2 and FF should begin to go down non-linearly
  • EGT should drop down fast until a certain point; then it will maintain heat energy and drop down very slowly until ambient temperature (it could take well over a number of hours)

(2) Testing for engine animation:

  • Start the aircraft C&D
  • Proceed to 'wake' the aircraft in order to start the engines
  • Go to External view and set yourself facing the engine. Go back in to the cockpit
  • To control engine spool while on outside view, decouple the E/WD
  • Set Engine Mode to IGN and Start an Engine
  • Go to the External View and watch the animation:
    (i) Engine should start spooling around 1 second after Master is on
    (ii) Engine rotation follows the start-up (and shutdown) FBW N1 (non-linear)

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Taz5150 Taz5150 changed the title feat/ fix: Engine shutdown and Start-up/ Shutdown animation feat: Engine shutdown and Start-up/ Shutdown animation Nov 30, 2021
@Taz5150 Taz5150 changed the title feat: Engine shutdown and Start-up/ Shutdown animation feat(engine/model): Engine shutdown and Start-up/ Shutdown animation Nov 30, 2021
@Taz5150 Taz5150 changed the title feat(engine/model): Engine shutdown and Start-up/ Shutdown animation feat(engine/model): engine shutdown and start-up/ shutdown animation Nov 30, 2021
@Taz5150 Taz5150 changed the title feat(engine/model): engine shutdown and start-up/ shutdown animation feat: engine shutdown and start-up/ shutdown animation Nov 30, 2021
@FlightSimmer7700
Copy link
Contributor

Quality Assurance Tester

Discord: FlightSimmer7700#5438
Object of testing: #6284
Tier of Testing: 1
Date: 30/11/21

Testing Process:
Loaded in C&D
Tested startup and shutdown on both engines while looking at ecam and animation
Tried crank mode
Tried wind animation
Loaded in on runway
Turned engine off and looked at ecam and animation
Restarted the flight and took off to then turn 1 engine off

Loaded in on dev to test 1 engine off during flight

Negatives:

  • When using Crank mode on the engine the animation used for this is still the old one which was used for normal engine start, it should probably be changed over to the new one

  • When in the air wind milling does not occur on this pr but does on dev

  • (not related to this pr) but the windmilling animation on the ground doesn't actually work unless the wind is over 70 knots on both dev and this pr which is way too high

Testing Results: Not passed

Conclusions: New animation is a lot better but just needs the crank animation changed and the windmilling while in the air
Media:
Crank: https://streamable.com/4qfs8b

Windmilling on this pr: https://streamable.com/jo2ypr

Windmilling on dev: https://youtu.be/gBf5Nr7K1PA

@mehoygg
Copy link

mehoygg commented Nov 30, 2021

Quality Assurance Tester/Trainee Report

Discord : mehoygg#1242
Object of testing: (#PR Number)
Tier of Testing : 1
Date : 30/11/21

Testing Process:
Section 1.
Spawned in at KLAX. Both engines were running and I did spool them up for a few seconds, before I shut both down. I also tested previously by shutting down one engine.
Engine spool down did start about 1 second after shuting down the master switch (external view).
N1, N2 and FF did shut down and went down at random, in case when shutting both engines down, it was very clear.
EGT went down fast till about hight 300's where it began to slow down all the way to about 180C. From there down it was very slow and at about 153C even slower. Took a little while to hit about 85C.

Section 2.

I started C/D at KLAX. I proceeded to get the aircraft ready for engine start.
I went to external view and face the aircraft head and and had a clear view of both engines. I do have the Thrustmaster Airbus TCA which made it much easier to start the engines from the outside.
Engies did start to spool within 1 second of master switch going to "ON." Engine rotation did follow N1 on start and shut down.

Negatives:
The only thing I did notice, unsure if its a bug or not or if it works that way, is, when engines are shut down and EGT is lowering, if while the EGT lowers, I went and restarted that engine, the engine's EGT would drop to Ambient Tempature instantly and start from that, i.e., at KLAX ambient temp was 15C, EGT was at around 85C and I started that same engine, it dropped to 15C and began to start.
Other than that, it looks great and small details like this that make it more realistc.

Testing Results:
Passed.

Conclusions:
It Passed. It looked great and was a great addition to the level of realism. It really looks like this when I am holding the plane (IRL work) and you can see them start the engines when the pilots get cleared.

Media:
Section 1 Video: https://www.youtube.com/watch?v=JroKUX6HxD4

Section 2 Video: https://www.youtube.com/watch?v=Orw1U2fNrR4

@Taz5150
Copy link
Contributor Author

Taz5150 commented Dec 1, 2021

Quality Assurance Tester

Discord: FlightSimmer7700#5438 Object of testing: #6284 Tier of Testing: 1 Date: 30/11/21

Testing Process: Loaded in C&D Tested startup and shutdown on both engines while looking at ecam and animation Tried crank mode Tried wind animation Loaded in on runway Turned engine off and looked at ecam and animation Restarted the flight and took off to then turn 1 engine off

Loaded in on dev to test 1 engine off during flight

Negatives:

  • When using Crank mode on the engine the animation used for this is still the old one which was used for normal engine start, it should probably be changed over to the new one
  • When in the air wind milling does not occur on this pr but does on dev
  • (not related to this pr) but the windmilling animation on the ground doesn't actually work unless the wind is over 70 knots on both dev and this pr which is way too high

Testing Results: Not passed

Conclusions: New animation is a lot better but just needs the crank animation changed and the windmilling while in the air Media: Crank: https://streamable.com/4qfs8b

Windmilling on this pr: https://streamable.com/jo2ypr

Windmilling on dev: https://youtu.be/gBf5Nr7K1PA

Thanks for the test and feedback. I did not take into consideration both cranking nor windmilling; I will look at it right away.

@Taz5150
Copy link
Contributor Author

Taz5150 commented Dec 1, 2021

Thank you for your test and feedback. Good call on the EGT issue when restarting the engine. Will work on it!

Quality Assurance Tester/Trainee Report

Discord : mehoygg#1242 Object of testing: (#PR Number) Tier of Testing : 1 Date : 30/11/21

Testing Process: Section 1. Spawned in at KLAX. Both engines were running and I did spool them up for a few seconds, before I shut both down. I also tested previously by shutting down one engine. Engine spool down did start about 1 second after shuting down the master switch (external view). N1, N2 and FF did shut down and went down at random, in case when shutting both engines down, it was very clear. EGT went down fast till about hight 300's where it began to slow down all the way to about 180C. From there down it was very slow and at about 153C even slower. Took a little while to hit about 85C.

Section 2.

I started C/D at KLAX. I proceeded to get the aircraft ready for engine start. I went to external view and face the aircraft head and and had a clear view of both engines. I do have the Thrustmaster Airbus TCA which made it much easier to start the engines from the outside. Engies did start to spool within 1 second of master switch going to "ON." Engine rotation did follow N1 on start and shut down.

Negatives: The only thing I did notice, unsure if its a bug or not or if it works that way, is, when engines are shut down and EGT is lowering, if while the EGT lowers, I went and restarted that engine, the engine's EGT would drop to Ambient Tempature instantly and start from that, i.e., at KLAX ambient temp was 15C, EGT was at around 85C and I started that same engine, it dropped to 15C and began to start. Other than that, it looks great and small details like this that make it more realistc.

Testing Results: Passed.

Conclusions: It Passed. It looked great and was a great addition to the level of realism. It really looks like this when I am holding the plane (IRL work) and you can see them start the engines when the pilots get cleared.

Media: Section 1 Video: https://www.youtube.com/watch?v=JroKUX6HxD4

Section 2 Video: https://www.youtube.com/watch?v=Orw1U2fNrR4

@mehoygg
Copy link

mehoygg commented Dec 8, 2021

Adding on to my previous report for the revised PR, it works as described now. EGT does not “reset” when starting an engine after it’s cooling down on shutdown. You can restart it and it’ll keep cooling down to a certain point where N1 and N2 start and it heats up fro, the temp at that point. Checks out good.

Windmilling does occur. Does need a good amount of wind, but definitely is there and works just as good as it looks.

This time around I still do believe it is in a PASSED state.

Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also gave it a quick test again, looks good!

@Saschl Saschl merged commit 0b3797e into flybywiresim:master Dec 15, 2021
@Taz5150 Taz5150 deleted the animation-test branch December 18, 2021 11:35
@2hwk 2hwk added this to the v0.8.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants