-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: engine shutdown and start-up/ shutdown animation #6284
Conversation
Quality Assurance Tester Discord: FlightSimmer7700#5438 Testing Process: Loaded in on dev to test 1 engine off during flight Negatives:
Testing Results: Not passed Conclusions: New animation is a lot better but just needs the crank animation changed and the windmilling while in the air Windmilling on this pr: https://streamable.com/jo2ypr Windmilling on dev: https://youtu.be/gBf5Nr7K1PA |
Quality Assurance Tester/Trainee Report Discord : mehoygg#1242 Testing Process:
I started C/D at KLAX. I proceeded to get the aircraft ready for engine start. Negatives: Testing Results: Conclusions: Media: Section 2 Video: https://www.youtube.com/watch?v=Orw1U2fNrR4 |
Thanks for the test and feedback. I did not take into consideration both cranking nor windmilling; I will look at it right away. |
Thank you for your test and feedback. Good call on the EGT issue when restarting the engine. Will work on it!
|
Adding on to my previous report for the revised PR, it works as described now. EGT does not “reset” when starting an engine after it’s cooling down on shutdown. You can restart it and it’ll keep cooling down to a certain point where N1 and N2 start and it heats up fro, the temp at that point. Checks out good. Windmilling does occur. Does need a good amount of wind, but definitely is there and works just as good as it looks. This time around I still do believe it is in a PASSED state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also gave it a quick test again, looks good!
Fixes #3169
Fixes #5119
Fixes #6301
Summary of Changes
This is a dual PR:
(i) Implements realistic engine shutdown, taking into account primary parameter behavior, including realistic EGT cooldown, and engine delay between master off and spool-down (around 1.2 seconds)
(ii) Realistic engine animation behavior at start-up and shutdown. Animation is now attached to the FBW N1 LVar, with fan starting right at the beginning of the process (not after ignition).
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): TazX [Z+2]#405
Testing instructions
(1) Testing for Engine Shutdown:
(2) Testing for engine animation:
(i) Engine should start spooling around 1 second after Master is on
(ii) Engine rotation follows the start-up (and shutdown) FBW N1 (non-linear)
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.