feat(displays): Add pixelated screens #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiaaryan
reviewed
Jul 23, 2021
flybywire-aircraft-a320-neo/html_ui/CSS/A32NX_Display_Common.css
Outdated
Show resolved
Hide resolved
Benjozork
reviewed
Jul 23, 2021
flybywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/model/A320_NEO_INTERIOR.xml
Show resolved
Hide resolved
Benjozork
approved these changes
Jul 24, 2021
|
Quality Assurance Report Discord: █▀█ █▄█ ▀█▀#2123 Testing Process: Spawned on runway, tested at varying times of day. Tested at different brightnesses and zoomed in on the various displays from different angles to check the screens. Negatives: Absolutely N/A Conclusions: Looks brilliant under all light conditions, pixels are barely visible from a distance and adds a pretty nice immersion. No issues at different screen brightnesses. All in all, a brilliant addition, kudos! |
hiaaryan
approved these changes
Jul 24, 2021
|
Beautiful x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens with different pixel density. DCDU checkered pixel pattern.
(watch images at 100% to see effect properly)
Summary of Changes
📕📗📘
This PR adds pixels to the following screens:
PFD- pixels, tint and subtle backlight bleedND- pixels, tint and subtle backlight bleedEICAS 1 + 2- pixels, tint and subtle backlight bleedDCDU 1 + 2- pixels (checkered), tintSAI/ISIS- pixels, tintFCU/MCDU- pixels, tintLarge screens have a subtle blue tint and a small backlight bleed that can be seen in the dark in a favorable setting (dark and high intensity setting).
DCDU screens have a light white tint and a checkered large pixel pattern.
Screenshots
MCDU, SAI/ISIS, letters and WX.
(watch images at 100% to see effect properly)
Subtle small backlight bleed can be seen on the large screens in favorable settings (dark and high intensity setting)
(watch image at 100% to see effect properly)
Dust and scratches are still visible.
(watch image at 100% to see effect properly)
References
Note the DCDU's checkered pixel pattern
Known behaviors
At some zoom levels and angles, a very minor unavoidable moiré effect can be observed.
Discord username: @bouveng
Testing instructions
1, Spawn on runway
2, Observe screens at different zoom levels and under various lighting conditions.
(you need to be somewhat close to see the pixels at all)
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.