feat(efb): flyPadOS v2 🚀 #4026

hiaaryan · 2021-03-19T05:25:27Z

Fixes: #4053
Fixes: #4075
Fixes: #4575

Important

Remove env file from PR workflow before merge.

Summary of Changes

flyPadOS v2. Full Layout & UI Rewrite. Special thanks to @Benjozork & @ZigTag!

Screenshots (if necessary)

Testing Instructions

Please thoroughly test every page (if you don't have a navigraph subscription don't worry about it).

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

frankkopp · 2021-06-21T00:09:05Z

Quality Assurance Tester Report

Discord: Cdr_Maverick#6475
Object of testing: #4026
Tier of Testing: 1
Date: 21.6.2021

Testing Process:
C&D at EDDF
Simbrief flightplan EDDF-EDDM
Checking each page and subpage
Dashboard

Simbrief import ==> OK [1]
Dispatch
OFP ==> OK (EZY format)
Fuel ==> OK (Defueling, Fueling)
Ground
Check all button functions
Performance
TOD: Ground Speed - see negatives ==> otherwise OK
Landing: see negatives ==> otherwise OK
Navigraph; ==> see negatives
ATC ==> OK
Settings ==> OK

Negatives:

General:
- Last subpage is not remembered - when changing to another page and back the first subpage is visible and not the last used [3] (this is annoying when for example on Landing performance jumping to Dashboard or OFP to lookup values)
Direct after starting tablet: Map icons transparent [0]
Link MCDU - not working / unclear what it should do
Ground Speed - Min Alt looks funny - can't edit (probably not meant to be editable) [2]
Landing: Metar does not fetch Wind Magnitude [4]
Landing: Clear does not work [4]
Navigraph:
- Insufficient .env file - unclear how to access Navigraph subscription (self compiled) - Works when run via PR artefact [5]
- looses selection when changing to other page and back
- List of charts - can't scroll with mouse wheel
ATC:
- ATIS font too small [6]
- no ATIS when using PR artefact / worked with self-compiled build [6][7]

Testing Results: Not Passed

Conclusions:
Great feature but still too many small issues imho.
Also there seem to be differences when compiled locally vs. PR build

Media:
[0] Map icons transparent

[1] Simbrief OFP

[2]

[3]
https://user-images.githubusercontent.com/16833201/122691149-1c4bf280-d22e-11eb-9b5e-6e186755424b.mp4
[4]
https://user-images.githubusercontent.com/16833201/122691409-c8daa400-d22f-11eb-9188-9e3b100f1eb4.mp4
[5] Navigraph

[6] ATC

[7]

Benjozork · 2021-06-21T00:19:12Z

Insufficient .env file - unclear how to access Navigraph subscription (self compiled) - Works when run via PR artefact [5]

This is expected and working as intended.

@frankkopp

Benjozork · 2021-06-21T00:25:25Z

The latest commit should fix the map panel and settings switches issue.

Can someone test when it's done building ?

St54Kevin · 2021-06-21T09:50:19Z

Quality Assurance Tester

Object of testing: #4026
Tier of Testing: 2
Date: 21/06/2021

Testing Process:

Loaded C&D an setup Settings page like I want it to, calibrated throttles -> Check issues
Checked dispatch page and refueled -> Check issues
Tested all ground services and pushback
Checked ATC page on this VATSIM flight
I do not have a navigraph charts sub
Played with ToD and LDG Calculators inflight

Negatives:

PTU toggle in settings page does not move, it just changes color
Something was wrong with the Dispatch page. I had no option to load my simbrief FPL. Username was set in the Settings menu. Consequently i also couldnt test OFP page
I also undestand the last subpage not being remembered may be a little annoying
ATC page does not update, when staying on it. But changing to another page and back to ATC, frequencies will update
ATC page didnt give me the TWR, GND and ATIS of LOWW although being within 50nm of the airport on approach

Testing Results: Not Passed due to the dispatch page problem, other than that i think its good to go

Conclusions: (Notes made, the positives in the PR, and anything extra you would like to mention - Delete Line if Nothing Extra is to be mentioned
Media:

easyjetsimpilot · 2021-06-21T14:33:59Z

Quality Assurance Tester

Discord: easyjetsimpilot
Object of testing: #4026
Tier of Testing: 2
Date: 21/06/21

Testing Process: Full flight which tested all pages and functions of the EFB OS v.2 (with Navigraph). All functions worked as expected.

Negatives:

OFP zoom/page not maintained when navigating away from the OFP page
Navigraph charts & selected airport not maintained when navigating away from the OFP page. Personally, I see this a a major issue. As you have to pop-out the EFB to type in the ICAO code (due to keybindings), this is time consuming if has to be done every time.
VATSIM page - not all available controllers were shown as available on the page when they were online (according to VPilot) - image above
Testing Results: Not Passed

Conclusions: Overall, everything works as it should - however, the 3 items above I feel need investigating - particularly the ability to maintain the pages of the VATSIM charts if navigating away from the page. Thanks for all the continued work.

ZeroKaa · 2021-06-21T17:57:05Z

Quality Assurance Tester

Object of testing: #4026
Tier of Testing: 2
Date: 21/06/2021

Testing Process:

Loaded C&D an setup Settings page like I want it to, calibrated throttles -> Check issues

Checked dispatch page and refueled -> Check issues

Tested all ground services and pushback

Checked ATC page on this VATSIM flight

I do not have a navigraph charts sub

Played with ToD and LDG Calculators inflight

Negatives:

PTU toggle in settings page does not move, it just changes color

Something was wrong with the Dispatch page. I had no option to load my simbrief FPL. Username was set in the Settings menu. Consequently i also couldnt test OFP page

I also undestand the last subpage not being remembered may be a little annoying

ATC page does not update, when staying on it. But changing to another page and back to ATC, frequencies will update

ATC page didnt give me the TWR, GND and ATIS of LOWW although being within 50nm of the airport on approach

Testing Results: Not Passed due to the dispatch page problem, other than that i think its good to go

Conclusions: (Notes made, the positives in the PR, and anything extra you would like to mention - Delete Line if Nothing Extra is to be mentioned
Media:

Hello. The ATC page is refreshing every two minutes. Wish is also the refresh rate of data coming from vatsim/Ivao.

frankkopp · 2021-06-21T21:04:40Z

Tested last commit for the map icons - OK now

St54Kevin · 2021-06-23T05:10:39Z

Hello. The ATC page is refreshing every two minutes. Wish is also the refresh rate of data coming from vatsim/Ivao.

My page did not update at all when coming into my Destination airport. So that's like 20min without an update. Even changing pages did not do anything.

ZeroKaa · 2021-06-23T06:56:58Z

Hello. The ATC page is refreshing every two minutes. Wish is also the refresh rate of data coming from vatsim/Ivao.

My page did not update at all when coming into my Destination airport. So that's like 20min without an update. Even changing pages did not do anything.

Ok Thanks. I'll do some extra tests because I cannot reproduce it. I'll plan a new flight

ZeroKaa · 2021-06-24T09:52:33Z

Hello. The ATC page is refreshing every two minutes. Wish is also the refresh rate of data coming from vatsim/Ivao.

My page did not update at all when coming into my Destination airport. So that's like 20min without an update. Even changing pages did not do anything.

@St54Kevin . I spot the issue and fixed it. PR still need to be merge
I also increased the font-size

marcman86 · 2021-07-01T08:45:06Z

Quality Assurance Tester Report
Discord:marcman86#4907
Object of testing: #4026
Tier of Testing: 1
Date: 1/07/2021

Testing Process:

Spawned C&D at EDDP
Start up AC and EFB
Checked Dashboard page and Simbrief sync
Checked Dispatch Overview, OFP and Fuel page
Checked Ground page
Took off
Checked Performance page (TOD and Landing)
Checked Navigation & Charts page (QR Code only)
Checked VATSIM page (i dont use VATSIM)
Checked Settings page
Checked Detents page

Negatives:

Map plane flickers
OFP dont remembers scroll position and zoom level
Fuel page plane looks a little pressed (close to the Refuel box), maybe put the fuel time and the plane a litte down
Fuel page fontsizes are inconsistent (left outer tank value, right outer tank value) (fig1)
Landing page fontsizes are inconsistent/to small (clear, low, medium, manual) (fig2)
I dont like the grey hairlines between each line on the setup page

Testing Results: (Not) Passed
Conclusions: Works, just minor fixes
Media:

fig1

fig2

Hope this helps :-)

* display page with the list of ATCs * code simplification * fix sorting issue * clean console.log * performance improvment * remove useless css file * add wrap for text atis * align with new api-client version * merge * merge * Revert "merge" This reverts commit db6ab62. * update api-client package * Update ATC.tsx * Revert "Update ATC.tsx" This reverts commit ef45e2b. * fix issue on atc list refresh * remove console.log * add atis controllers in ATC page * remove console.log * decrease refresh rate * fix refresh issue * remove double load * increase font-size * fix distance calculation * use useCallback and useInterval * add atisSource as dependency * try to repect rules of hook

St54Kevin · 2021-07-12T21:32:16Z

Quality Assurance Tester

Object of testing: #4026
Tier of Testing: 2
Date: 12/07/2021

Testing Process:

Full VATSIM EGLL-EDDF flight
Went through all the settings and set everything up to my liking
Loaded simbrief flight plan, refueled via EFB
Tested every ground service
caculated relanding performance
Used ATC tab to tune frequency
EFB pushback did not work
Full flight with monitoring ATC tab and vPilot Controllers
Unfortunately all controllers went offline right after my departure, therefor I wrote this qa airborne (nothing more to test)

Negatives:

Sometimes the EFB doesnt take my click when switching pages. I need to click several times to get them to open. But its just from time to time but noticeable
After calling the baggage, shutting it off didnt work, button was blue but services were stuck at the plane, the door even stayed open with ENG running(see media), I think this was causing my EFB pushback to not work. Had to use pushback toolbar for both problems. I literally did a full flight this evening with master and it was working fine there
The Map didnt have a plane icon to indicate my position

Testing Results: Passed. I couldnt reproduce the ground services bug on another airport

Media:

St54Kevin · 2021-07-12T21:45:46Z

Just tested with the same sim on a different airport (EDDW) and ground services just worked fine. Maybe that was due to the EGLL scenery. Changed qa to Passed

hiaaryan closed this Mar 19, 2021

ZigTag reopened this Mar 19, 2021

ZigTag marked this pull request as ready for review March 19, 2021 06:20

ZigTag marked this pull request as draft March 19, 2021 06:39

ZigTag marked this pull request as ready for review March 19, 2021 06:44

hiaaryan marked this pull request as draft March 19, 2021 07:18

hiaaryan added the EFB label Mar 19, 2021

hiaaryan force-pushed the flypados-v2 branch 2 times, most recently from 4a9d3df to 13d2a47 Compare March 22, 2021 08:43

Benjozork added this to the v0.6.0 milestone Mar 22, 2021

derl30n mentioned this pull request Mar 22, 2021

OFP on EFB does not use mono-spaced font #4075

Closed

derl30n linked an issue Mar 22, 2021 that may be closed by this pull request

OFP on EFB does not use mono-spaced font #4075

Closed

ZigTag force-pushed the flypados-v2 branch 2 times, most recently from f5ff1be to 0431530 Compare March 26, 2021 21:59

Benjozork changed the title ~~feat(efb): FlyPadOS v2 🚀~~ feat(efb): flyPadOS v2 🚀 Apr 3, 2021

hiaaryan marked this pull request as ready for review April 3, 2021 11:10

hiaaryan marked this pull request as draft April 3, 2021 16:40

Benjozork modified the milestones: v0.6.0, v0.7.0 Apr 4, 2021

ZigTag force-pushed the flypados-v2 branch from 0431530 to 514637b Compare April 6, 2021 01:03

hiaaryan force-pushed the flypados-v2 branch 3 times, most recently from 9e5d074 to 5b778ef Compare April 10, 2021 19:09

hiaaryan force-pushed the flypados-v2 branch 6 times, most recently from 28a747d to 560d314 Compare April 19, 2021 16:05

hiaaryan force-pushed the flypados-v2 branch from 560d314 to 4590c65 Compare April 21, 2021 17:30

fix: bad tailwind safelist path

b544013

Merge branch 'master' into flypados-v2

3ab916c

fix: actually fix react-components classes purging this time

39d9c95

Merge branch 'master' into flypados-v2

56699f5

Merge branch 'master' into flypados-v2

3413adb

hiaaryan and others added 8 commits July 3, 2021 10:38

Merge branch 'master' into flypados-v2

de8b46c

Merge branch 'master' into flypados-v2

f36a219

fix lint 🌌

5c50cc3

disable JIT, because rollup 🎱

d3e3596

fix fuel page layout ⚡

216c294

fix button font size ☁️

e89a8f3

Merge branch 'master' into flypados-v2

2af8cb9

hiaaryan merged commit cf88fc3 into master Jul 12, 2021

tracernz mentioned this pull request Jul 16, 2021

[REQUEST] Integrate the EFB with Navigraph #1831

Closed

davidwalschots deleted the flypados-v2 branch November 3, 2021 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(efb): flyPadOS v2 🚀 #4026

feat(efb): flyPadOS v2 🚀 #4026

hiaaryan commented Mar 19, 2021 •

edited

Loading

frankkopp commented Jun 21, 2021

Benjozork commented Jun 21, 2021 •

edited

Loading

Benjozork commented Jun 21, 2021 •

edited

Loading

St54Kevin commented Jun 21, 2021 •

edited

Loading

easyjetsimpilot commented Jun 21, 2021 •

edited

Loading

ZeroKaa commented Jun 21, 2021

frankkopp commented Jun 21, 2021

St54Kevin commented Jun 23, 2021

ZeroKaa commented Jun 23, 2021

ZeroKaa commented Jun 24, 2021

marcman86 commented Jul 1, 2021 •

edited

Loading

St54Kevin commented Jul 12, 2021 •

edited

Loading

St54Kevin commented Jul 12, 2021 •

edited

Loading

feat(efb): flyPadOS v2 🚀 #4026

feat(efb): flyPadOS v2 🚀 #4026

Conversation

hiaaryan commented Mar 19, 2021 • edited Loading

Important

Summary of Changes

Screenshots (if necessary)

Testing Instructions

How to download the PR for QA

frankkopp commented Jun 21, 2021

Benjozork commented Jun 21, 2021 • edited Loading

Benjozork commented Jun 21, 2021 • edited Loading

St54Kevin commented Jun 21, 2021 • edited Loading

easyjetsimpilot commented Jun 21, 2021 • edited Loading

ZeroKaa commented Jun 21, 2021

frankkopp commented Jun 21, 2021

St54Kevin commented Jun 23, 2021

ZeroKaa commented Jun 23, 2021

ZeroKaa commented Jun 24, 2021

marcman86 commented Jul 1, 2021 • edited Loading

St54Kevin commented Jul 12, 2021 • edited Loading

St54Kevin commented Jul 12, 2021 • edited Loading

hiaaryan commented Mar 19, 2021 •

edited

Loading

Benjozork commented Jun 21, 2021 •

edited

Loading

Benjozork commented Jun 21, 2021 •

edited

Loading

St54Kevin commented Jun 21, 2021 •

edited

Loading

easyjetsimpilot commented Jun 21, 2021 •

edited

Loading

marcman86 commented Jul 1, 2021 •

edited

Loading

St54Kevin commented Jul 12, 2021 •

edited

Loading

St54Kevin commented Jul 12, 2021 •

edited

Loading