Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gettext #1169

Merged
merged 3 commits into from
Sep 1, 2024
Merged

chore: update gettext #1169

merged 3 commits into from
Sep 1, 2024

Conversation

Doublonmousse
Copy link
Collaborator

Add a note for building on mac os.

From gettext-rs/gettext-rs@11a78d6, this shouldn't be needed once gettext-rs releases a new version.

I'll leave this as a draft for now, and maybe change this to a version upgrade once gettext-rs is updated.

@flxzt
Copy link
Owner

flxzt commented Aug 31, 2024

Looks like there is a new release now! https://github.com/gettext-rs/gettext-rs/releases/tag/gettext-sys-0.21.4

@Doublonmousse Doublonmousse changed the title Update rnote-macos-build.md chore: update gettext Aug 31, 2024
@Doublonmousse
Copy link
Collaborator Author

You're right. Just tested on mac os and it works now !

@Doublonmousse Doublonmousse marked this pull request as ready for review August 31, 2024 07:52
@flxzt
Copy link
Owner

flxzt commented Sep 1, 2024

thanks!

@flxzt flxzt merged commit f2f044a into flxzt:main Sep 1, 2024
2 checks passed
@Doublonmousse Doublonmousse deleted the mac_os branch September 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants