feat(share_plus)!: Introduce optional parameter nameOverride to shareXFiles.
#3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reXFiles`. This enables file names to be set for XFiles created from data. See issue [fluttercommunity#3032](fluttercommunity#3032)
|
Thanks @frieder-audriga I'd have much preferred that the |
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
Applied suggestions from code review Co-authored-by: Miguel Beltran <[email protected]>
|
Thank you for the comments and suggestions. I added a short subsection to the README and addressed the other comments. |
| @@ -61,12 +61,14 @@ class SharePlatform extends PlatformInterface { | |||
| String? subject, | |||
| String? text, | |||
| Rect? sharePositionOrigin, | |||
| List<String>? fileNameOverrides, | |||
There was a problem hiding this comment.
Because we are changing the platform interface, this requires a major version, otherwise this will cause issues with clients where the platform interface and the main package are not in sync.
miquelbeltran
changed the title
nameOverride to shareXFiles.nameOverride to shareXFiles.
miquelbeltran
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Tested on Android. LGTM! I did some changes and pushed them to @frieder-audriga fork.
This feature has to be marked as a breaking change since it modifies the platform interface API. fyi @vbuberen
I'll wait a bit and then it can be merged.
miquelbeltran
added
PR: pending to merge
and removed
PR: needs review
PR: needs manual testing
labels
vbuberen
approved these changes
Jul 14, 2024
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Volodymyr Buberenko <[email protected]>
Co-authored-by: Volodymyr Buberenko <[email protected]>
Co-authored-by: Volodymyr Buberenko <[email protected]>
Co-authored-by: Volodymyr Buberenko <[email protected]>
…hannel/method_channel_share.dart Co-authored-by: Volodymyr Buberenko <[email protected]>
…hannel/method_channel_share.dart Co-authored-by: Volodymyr Buberenko <[email protected]>
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nameOverrideto funcitonshareXFilesnameOverridewill be used as the file names for the files shareXFile.fromDataignoresnameparameter on platforms other than web.Related Issues
XFile.nameas the shared file name #1548Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).