Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deep link] Add more explanation for cross checking. #8020

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

hangyujin
Copy link
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR.

Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@hangyujin hangyujin requested a review from a team as a code owner July 3, 2024 21:12
@hangyujin hangyujin requested review from kenzieschmoll and removed request for a team July 3, 2024 21:12
@hangyujin hangyujin changed the title [deep link] Add more explaination for cross checking. [deep link] Add more explanation for cross checking. Jul 3, 2024
Padding(
padding: EdgeInsets.symmetric(horizontal: defaultSpacing),
child: Text(
'This domain has an Asset link json file but it\'s missing in android manifest file. '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in 'the' android manifest file

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit

@hangyujin hangyujin merged commit 8935f28 into flutter:master Jul 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants