Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge2d codelab] Use flame_kenney_xml instead of manual XML parsing #2211

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

spydon
Copy link
Contributor

@spydon spydon commented Jun 25, 2024

This simplifies the forge2d codelab by using the flame_kenney_xml package (official Flame package) for parsing the Kenney sprite sheets. (It pretty much contains the same code as @domesticmouse previously wrote for this codelab)

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@spydon
Copy link
Contributor Author

spydon commented Jun 25, 2024

Oh, it bumped some dependencies when running codelab_rebuild too.

@domesticmouse domesticmouse self-assigned this Jun 25, 2024
@spydon
Copy link
Contributor Author

spydon commented Jun 26, 2024

The diffs are not correct, I should have just edited the files and getting the diffs instead of directly editing the code_rebuild.yaml 😅

@domesticmouse domesticmouse self-requested a review June 30, 2024 09:13
@domesticmouse
Copy link
Contributor

Thank you for this PR @spydon!

I doubt I'm going to have time to update the codelab text and domesticmouse/forge2d_workshop_presentation before I/O Connect Bengaluru. See how the next couple of weeks go.

@spydon
Copy link
Contributor Author

spydon commented Jun 30, 2024

Thank you for this PR @spydon!

I doubt I'm going to have time to update the codelab text and domesticmouse/forge2d_workshop_presentation before I/O Connect Bengaluru. See how the next couple of weeks go.

Thanks a lot for fixing it up!
I was a bit too busy now with I/O Connect Berlin and FlutterCon.

I might be able to help with the text once I'm back from Berlin. :)

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll land once the codelab text and presentation app have also been updated.

@domesticmouse
Copy link
Contributor

I think I've updated the codelab text. Just waiting on @RedBrogdon to sign off the updated codelab for publication before landing this PR.

@domesticmouse domesticmouse merged commit 92767a6 into flutter:main Aug 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants