-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[forge2d codelab] Use flame_kenney_xml instead of manual XML parsing #2211
Conversation
Oh, it bumped some dependencies when running |
The diffs are not correct, I should have just edited the files and getting the diffs instead of directly editing the |
Thank you for this PR @spydon! I doubt I'm going to have time to update the codelab text and |
Thanks a lot for fixing it up! I might be able to help with the text once I'm back from Berlin. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll land once the codelab text and presentation app have also been updated.
I think I've updated the codelab text. Just waiting on @RedBrogdon to sign off the updated codelab for publication before landing this PR. |
This simplifies the forge2d codelab by using the flame_kenney_xml package (official Flame package) for parsing the Kenney sprite sheets. (It pretty much contains the same code as @domesticmouse previously wrote for this codelab)
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.