Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoveltySlice: Unpredictable silences after parameter changes #128

Open
tremblap opened this issue Apr 12, 2022 · 5 comments · Fixed by #129
Open

NoveltySlice: Unpredictable silences after parameter changes #128

tremblap opened this issue Apr 12, 2022 · 5 comments · Fixed by #129
Assignees
Labels
bug Something isn't working

Comments

@tremblap
Copy link
Member

if one opens the musical example tab (2) of the max helpfile (correcting the algorithm in the message to get to mfcc) one gets either nothing detected, or a continuous flow of attacks. One then needs to change the threshold to get something sensible out but it is very tempremental.

to reproduce:

  • open the help with DAC off, on the 2nd tab
  • choose nicol drum loop
  • play - nothing or a lot of clicks.
  • if nothing, press reset. usually, a lot of clicks
  • press the message to change preset. usually a lot of clicks. raising the threshold a little helps to tame but is strangely inconsistent.

this happened first in Pd and is tested behaviour in Max too. Beta5 and beta6. I will download beta4 and see if it is the same.

@tremblap
Copy link
Member Author

ok I can confirm that in beta4 everything is fine and as expected. something happened between beta4 and beta5 that makes this object erratic...

@weefuzzy
Copy link
Member

I'm not sure how many problems you're describing here.

  • Yes, I can reproduce inconsistency when there's a param change and it just shuts up
  • Are you also saying that those settings in the message box gave results that weren't just a click fest with nicol? Because they're pretty lively settings.

@tremblap
Copy link
Member Author

  1. good that you can reproduce the inconsistancy.

  2. as for results, in beta4 it grooves, in beta5 it sounds like popcorn, for these settings. Same in SC (although I couldn't reproduce the 'silence' problem Missing space in invalid buffer error message  #1

@weefuzzy
Copy link
Member

The first of these I've found the cause for. a4bb226 made something stateful but didn't reset it when needed.

The second one I'm think is a side effect of 03710d8: when we fixed the internal MFCCs to run up to 20kHz on the source signal, useful thresholds would have changed. 0.018 seems ok here.

@weefuzzy weefuzzy changed the title noveltyslice misbehaving NoveltySlice: Unpredictable silences after parameter changes Apr 13, 2022
@weefuzzy weefuzzy added the bug Something isn't working label Apr 13, 2022
@weefuzzy weefuzzy linked a pull request Apr 13, 2022 that will close this issue
@tremblap
Copy link
Member Author

ok good so #1 is a real bug and #2 I can fix in all help the threshold in the help

weefuzzy added a commit that referenced this issue Apr 13, 2022
`NoveltySlice`: Fix reset after parameter change (issue #128)
fearn-e pushed a commit to fearn-e/flucoma-core that referenced this issue Aug 15, 2023
* grid out help

* update patcher

* PA review

Co-authored-by: James Bradbury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants