Skip to content

Commit

Permalink
Rip out all the u"..." literals and calls to unicode().
Browse files Browse the repository at this point in the history
  • Loading branch information
gvanrossum committed May 2, 2007
1 parent 572dbf8 commit ef87d6e
Show file tree
Hide file tree
Showing 200 changed files with 18,059 additions and 18,059 deletions.
2 changes: 1 addition & 1 deletion Lib/HTMLParser.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def replaceEntities(s):
# which is not part of HTML 4
import htmlentitydefs
if HTMLParser.entitydefs is None:
entitydefs = HTMLParser.entitydefs = {'apos':u"'"}
entitydefs = HTMLParser.entitydefs = {'apos':"'"}
for k, v in htmlentitydefs.name2codepoint.items():
entitydefs[k] = unichr(v)
try:
Expand Down
2 changes: 1 addition & 1 deletion Lib/codecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ def reset(self):
"""
self.bytebuffer = ""
self.charbuffer = u""
self.charbuffer = ""
self.linebuffer = None

def seek(self, offset, whence=0):
Expand Down
6 changes: 3 additions & 3 deletions Lib/compiler/transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ def decode_literal(self, lit):
# hack... changes in compile.c:parsestr and
# tokenizer.c must be reflected here.
if self.encoding not in ['utf-8', 'iso-8859-1']:
lit = unicode(lit, 'utf-8').encode(self.encoding)
lit = str(lit, 'utf-8').encode(self.encoding)
return eval("# coding: %s\n%s" % (self.encoding, lit))
else:
return eval(lit)
Expand All @@ -750,7 +750,7 @@ def atom_string(self, nodelist):
for node in nodelist[1:]:
k += self.decode_literal(node[1])
if isinstance(k, bytes):
return Bytes(str(k), lineno=nodelist[0][2])
return Bytes(str(k), lineno=nodelist[0][2])
return Const(k, lineno=nodelist[0][2])

def atom_ellipsis(self, nodelist):
Expand Down Expand Up @@ -825,7 +825,7 @@ def _simplearg(self, node):
else:
annotation = None
return SimpleArg(name, annotation, lineno)

def com_arglist(self, nodelist):
# varargslist:
# (fpdef ['=' test] ',')*
Expand Down
2 changes: 1 addition & 1 deletion Lib/cookielib.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ def escape_path(path):
# And here, kind of: draft-fielding-uri-rfc2396bis-03
# (And in draft IRI specification: draft-duerst-iri-05)
# (And here, for new URI schemes: RFC 2718)
if isinstance(path, unicode):
if isinstance(path, str):
path = path.encode("utf-8")
path = urllib.quote(path, HTTP_PATH_SAFE)
path = ESCAPED_CHAR_RE.sub(uppercase_escaped_char, path)
Expand Down
2 changes: 1 addition & 1 deletion Lib/copy.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def _deepcopy_atomic(x, memo):
pass
d[str] = _deepcopy_atomic
try:
d[unicode] = _deepcopy_atomic
d[str] = _deepcopy_atomic
except NameError:
pass
try:
Expand Down
4 changes: 2 additions & 2 deletions Lib/ctypes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def create_string_buffer(init, size=None):
create_string_buffer(anInteger) -> character array
create_string_buffer(aString, anInteger) -> character array
"""
if isinstance(init, (str, unicode)):
if isinstance(init, (str, str)):
if size is None:
size = len(init)+1
buftype = c_char * size
Expand Down Expand Up @@ -281,7 +281,7 @@ def create_unicode_buffer(init, size=None):
create_unicode_buffer(anInteger) -> character array
create_unicode_buffer(aString, anInteger) -> character array
"""
if isinstance(init, (str, unicode)):
if isinstance(init, (str, str)):
if size is None:
size = len(init)+1
buftype = c_wchar * size
Expand Down
2 changes: 1 addition & 1 deletion Lib/ctypes/macholib/dyld.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

def ensure_utf8(s):
"""Not all of PyObjC and Python understand unicode paths very well yet"""
if isinstance(s, unicode):
if isinstance(s, str):
return s.encode('utf8')
return s

Expand Down
2 changes: 1 addition & 1 deletion Lib/ctypes/test/test_as_parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def test_wchar_parm(self):
return
f = dll._testfunc_i_bhilfd
f.argtypes = [c_byte, c_wchar, c_int, c_long, c_float, c_double]
result = f(self.wrap(1), self.wrap(u"x"), self.wrap(3), self.wrap(4), self.wrap(5.0), self.wrap(6.0))
result = f(self.wrap(1), self.wrap("x"), self.wrap(3), self.wrap(4), self.wrap(5.0), self.wrap(6.0))
self.failUnlessEqual(result, 139)
self.failUnless(type(result), int)

Expand Down
14 changes: 7 additions & 7 deletions Lib/ctypes/test/test_buffers.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_buffer(self):
self.failUnlessEqual(b[:], "abc\0")

def test_string_conversion(self):
b = create_string_buffer(u"abc")
b = create_string_buffer("abc")
self.failUnlessEqual(len(b), 4) # trailing nul char
self.failUnlessEqual(sizeof(b), 4 * sizeof(c_char))
self.failUnless(type(b[0]) is str)
Expand All @@ -33,21 +33,21 @@ def test_unicode_buffer(self):
b = create_unicode_buffer(32)
self.failUnlessEqual(len(b), 32)
self.failUnlessEqual(sizeof(b), 32 * sizeof(c_wchar))
self.failUnless(type(b[0]) is unicode)
self.failUnless(type(b[0]) is str)

b = create_unicode_buffer(u"abc")
b = create_unicode_buffer("abc")
self.failUnlessEqual(len(b), 4) # trailing nul char
self.failUnlessEqual(sizeof(b), 4 * sizeof(c_wchar))
self.failUnless(type(b[0]) is unicode)
self.failUnlessEqual(b[0], u"a")
self.failUnless(type(b[0]) is str)
self.failUnlessEqual(b[0], "a")
self.failUnlessEqual(b[:], "abc\0")

def test_unicode_conversion(self):
b = create_unicode_buffer("abc")
self.failUnlessEqual(len(b), 4) # trailing nul char
self.failUnlessEqual(sizeof(b), 4 * sizeof(c_wchar))
self.failUnless(type(b[0]) is unicode)
self.failUnlessEqual(b[0], u"a")
self.failUnless(type(b[0]) is str)
self.failUnlessEqual(b[0], "a")
self.failUnlessEqual(b[:], "abc\0")

if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions Lib/ctypes/test/test_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_wchar_parm(self):
return
f = dll._testfunc_i_bhilfd
f.argtypes = [c_byte, c_wchar, c_int, c_long, c_float, c_double]
result = f(1, u"x", 3, 4, 5.0, 6.0)
result = f(1, "x", 3, 4, 5.0, 6.0)
self.failUnlessEqual(result, 139)
self.failUnlessEqual(type(result), int)

Expand All @@ -83,7 +83,7 @@ def test_wchar_result(self):
f.argtypes = [c_byte, c_short, c_int, c_long, c_float, c_double]
f.restype = c_wchar
result = f(0, 0, 0, 0, 0, 0)
self.failUnlessEqual(result, u'\x00')
self.failUnlessEqual(result, '\x00')

def test_voidresult(self):
f = dll._testfunc_v
Expand Down
10 changes: 5 additions & 5 deletions Lib/ctypes/test/test_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def test_cstrings(self):
self.failUnless(c_char_p.from_param(s)._obj is s)

# new in 0.9.1: convert (encode) unicode to ascii
self.failUnlessEqual(c_char_p.from_param(u"123")._obj, "123")
self.assertRaises(UnicodeEncodeError, c_char_p.from_param, u"123\377")
self.failUnlessEqual(c_char_p.from_param("123")._obj, "123")
self.assertRaises(UnicodeEncodeError, c_char_p.from_param, "123\377")

self.assertRaises(TypeError, c_char_p.from_param, 42)

Expand All @@ -75,16 +75,16 @@ def test_cw_strings(self):
except ImportError:
## print "(No c_wchar_p)"
return
s = u"123"
s = "123"
if sys.platform == "win32":
self.failUnless(c_wchar_p.from_param(s)._obj is s)
self.assertRaises(TypeError, c_wchar_p.from_param, 42)

# new in 0.9.1: convert (decode) ascii to unicode
self.failUnlessEqual(c_wchar_p.from_param("123")._obj, u"123")
self.failUnlessEqual(c_wchar_p.from_param("123")._obj, "123")
self.assertRaises(UnicodeDecodeError, c_wchar_p.from_param, "123\377")

pa = c_wchar_p.from_param(c_wchar_p(u"123"))
pa = c_wchar_p.from_param(c_wchar_p("123"))
self.failUnlessEqual(type(pa), c_wchar_p)

def test_int_pointers(self):
Expand Down
16 changes: 8 additions & 8 deletions Lib/ctypes/test/test_prototypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_c_void_p_arg(self):
pass
else:
self.failUnlessEqual(None, func(c_wchar_p(None)))
self.failUnlessEqual(u"123", func(c_wchar_p(u"123")))
self.failUnlessEqual("123", func(c_wchar_p("123")))

def test_instance(self):
func = testdll._testfunc_p_p
Expand Down Expand Up @@ -157,24 +157,24 @@ def test_POINTER_c_wchar_arg(self):
func.argtypes = POINTER(c_wchar),

self.failUnlessEqual(None, func(None))
self.failUnlessEqual(u"123", func(u"123"))
self.failUnlessEqual("123", func("123"))
self.failUnlessEqual(None, func(c_wchar_p(None)))
self.failUnlessEqual(u"123", func(c_wchar_p(u"123")))
self.failUnlessEqual("123", func(c_wchar_p("123")))

self.failUnlessEqual(u"123", func(c_wbuffer(u"123")))
self.failUnlessEqual("123", func(c_wbuffer("123")))
ca = c_wchar("a")
self.failUnlessEqual(u"a", func(pointer(ca))[0])
self.failUnlessEqual(u"a", func(byref(ca))[0])
self.failUnlessEqual("a", func(pointer(ca))[0])
self.failUnlessEqual("a", func(byref(ca))[0])

def test_c_wchar_p_arg(self):
func = testdll._testfunc_p_p
func.restype = c_wchar_p
func.argtypes = c_wchar_p,

c_wchar_p.from_param(u"123")
c_wchar_p.from_param("123")

self.failUnlessEqual(None, func(None))
self.failUnlessEqual("123", func(u"123"))
self.failUnlessEqual("123", func("123"))
self.failUnlessEqual(None, func(c_wchar_p(None)))
self.failUnlessEqual("123", func(c_wchar_p("123")))

Expand Down
6 changes: 3 additions & 3 deletions Lib/ctypes/test/test_slicing.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_char_ptr(self):

import operator
self.assertRaises(TypeError, operator.setslice,
res, 0, 5, u"abcde")
res, 0, 5, "abcde")
dll.my_free(res)

dll.my_strdup.restype = POINTER(c_byte)
Expand Down Expand Up @@ -88,7 +88,7 @@ def test_char_array(self):
pass
else:
def test_wchar_ptr(self):
s = u"abcdefghijklmnopqrstuvwxyz\0"
s = "abcdefghijklmnopqrstuvwxyz\0"

dll = CDLL(_ctypes_test.__file__)
dll.my_wcsdup.restype = POINTER(c_wchar)
Expand All @@ -99,7 +99,7 @@ def test_wchar_ptr(self):

import operator
self.assertRaises(TypeError, operator.setslice,
res, 0, 5, u"abcde")
res, 0, 5, "abcde")
dll.my_free(res)

if sizeof(c_wchar) == sizeof(c_short):
Expand Down
46 changes: 23 additions & 23 deletions Lib/ctypes/test/test_strings.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,17 @@ class WStringArrayTestCase(unittest.TestCase):
def test(self):
BUF = c_wchar * 4

buf = BUF(u"a", u"b", u"c")
self.failUnlessEqual(buf.value, u"abc")
buf = BUF("a", "b", "c")
self.failUnlessEqual(buf.value, "abc")

buf.value = u"ABCD"
self.failUnlessEqual(buf.value, u"ABCD")
buf.value = "ABCD"
self.failUnlessEqual(buf.value, "ABCD")

buf.value = u"x"
self.failUnlessEqual(buf.value, u"x")
buf.value = "x"
self.failUnlessEqual(buf.value, "x")

buf[1] = u"Z"
self.failUnlessEqual(buf.value, u"xZCD")
buf[1] = "Z"
self.failUnlessEqual(buf.value, "xZCD")

class StringTestCase(unittest.TestCase):
def XX_test_basic_strings(self):
Expand All @@ -99,7 +99,7 @@ def XX_test_basic_strings(self):
self.failUnlessEqual(cs.value, "XY")
self.failUnlessEqual(cs.raw, "XY\000\000\000\000\000")

self.assertRaises(TypeError, c_string, u"123")
self.assertRaises(TypeError, c_string, "123")

def XX_test_sized_strings(self):

Expand Down Expand Up @@ -142,44 +142,44 @@ def XX_test_toolong(self):
else:
class WStringTestCase(unittest.TestCase):
def test_wchar(self):
c_wchar(u"x")
repr(byref(c_wchar(u"x")))
c_wchar("x")
repr(byref(c_wchar("x")))
c_wchar("x")


def X_test_basic_wstrings(self):
cs = c_wstring(u"abcdef")
cs = c_wstring("abcdef")

# XXX This behaviour is about to change:
# len returns the size of the internal buffer in bytes.
# This includes the terminating NUL character.
self.failUnless(sizeof(cs) == 14)

# The value property is the string up to the first terminating NUL.
self.failUnless(cs.value == u"abcdef")
self.failUnless(c_wstring(u"abc\000def").value == u"abc")
self.failUnless(cs.value == "abcdef")
self.failUnless(c_wstring("abc\000def").value == "abc")

self.failUnless(c_wstring(u"abc\000def").value == u"abc")
self.failUnless(c_wstring("abc\000def").value == "abc")

# The raw property is the total buffer contents:
self.failUnless(cs.raw == u"abcdef\000")
self.failUnless(c_wstring(u"abc\000def").raw == u"abc\000def\000")
self.failUnless(cs.raw == "abcdef\000")
self.failUnless(c_wstring("abc\000def").raw == "abc\000def\000")

# We can change the value:
cs.value = u"ab"
self.failUnless(cs.value == u"ab")
self.failUnless(cs.raw == u"ab\000\000\000\000\000")
cs.value = "ab"
self.failUnless(cs.value == "ab")
self.failUnless(cs.raw == "ab\000\000\000\000\000")

self.assertRaises(TypeError, c_wstring, "123")
self.assertRaises(ValueError, c_wstring, 0)

def X_test_toolong(self):
cs = c_wstring(u"abcdef")
cs = c_wstring("abcdef")
# Much too long string:
self.assertRaises(ValueError, setattr, cs, "value", u"123456789012345")
self.assertRaises(ValueError, setattr, cs, "value", "123456789012345")

# One char too long values:
self.assertRaises(ValueError, setattr, cs, "value", u"1234567")
self.assertRaises(ValueError, setattr, cs, "value", "1234567")


def run_test(rep, msg, func, arg):
Expand Down
10 changes: 5 additions & 5 deletions Lib/ctypes/test/test_structures.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,15 +269,15 @@ class PersonW(Structure):
_fields_ = [("name", c_wchar * 12),
("age", c_int)]

p = PersonW(u"Someone")
p = PersonW("Someone")
self.failUnlessEqual(p.name, "Someone")

self.failUnlessEqual(PersonW(u"1234567890").name, u"1234567890")
self.failUnlessEqual(PersonW(u"12345678901").name, u"12345678901")
self.failUnlessEqual(PersonW("1234567890").name, "1234567890")
self.failUnlessEqual(PersonW("12345678901").name, "12345678901")
# exact fit
self.failUnlessEqual(PersonW(u"123456789012").name, u"123456789012")
self.failUnlessEqual(PersonW("123456789012").name, "123456789012")
#too long
self.assertRaises(ValueError, PersonW, u"1234567890123")
self.assertRaises(ValueError, PersonW, "1234567890123")

def test_init_errors(self):
class Phone(Structure):
Expand Down
Loading

0 comments on commit ef87d6e

Please sign in to comment.