Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'off' callback may be a bound or an unbound function #222

Merged
merged 3 commits into from
Feb 18, 2014

Conversation

angus-c
Copy link
Contributor

@angus-c angus-c commented Feb 18, 2014

Previously we were assuming the off callback was the original function. This covers the case where it is a bound function.

@sayrer
Copy link
Collaborator

sayrer commented Feb 18, 2014

patch looks good but travis failing due to missing jquery?

@angus-c
Copy link
Contributor Author

angus-c commented Feb 18, 2014

yep travis issue looks like - bower install is failing
want to clean up a couple of things anyway - so not quite pull-ready

@angus-c
Copy link
Contributor Author

angus-c commented Feb 18, 2014

fixed travis issue (jquery-bower deploy path changed) and cleaned up code

sayrer added a commit that referenced this pull request Feb 18, 2014
'off' callback may be a bound or an unbound function
@sayrer sayrer merged commit 7514a91 into master Feb 18, 2014
@necolas necolas deleted the clean_up_bound_array branch June 25, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants