Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails into the queue too! #2096

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Emails into the queue too! #2096

merged 1 commit into from
Apr 3, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

@askvortsov1 askvortsov1 commented Mar 28, 2020 •
edited
Loading

Fixes #978
Fixes #1920

Changes proposed in this pull request:
Send emails through the queue. Thank you luceos for all your hard work setting this up with notifications!

Reviewers should focus on:
Did I mess anything up that I should not have messed up?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

franzliedke
franzliedke approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sensible, thanks!

@luceos Would you like to try this out on your system? (You have a "real" queue driver set up, IIRC, right?)

@franzliedke franzliedke requested a review from luceos April 3, 2020 09:51
@luceos
Copy link
Member

luceos commented Apr 3, 2020

Yes. Will do.

luceos
luceos approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the Redis driver that this works. One obvious consideration is that this overhead is pretty superfluous with non standard drivers like log 😂

@luceos luceos merged commit 03a4997 into flarum:master Apr 3, 2020
@luceos luceos added this to the 0.1.0-beta.13 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzliedke franzliedke franzliedke approved these changes

@luceos luceos luceos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-beta.13
Development

Successfully merging this pull request may close these issues.

Registration issue Use queues for sending emails
3 participants
@askvortsov1 @luceos @franzliedke