-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_tools: bool = True problem with actions #25
Comments
if use_tools: bool = False in agents.py and "USE_TOOLS": "True" in json config : Please let me know if you would like more information on any specific model or if you have any other questions. <END_OF_TURN>
if use_tools: bool = False in agents.py and "use_tools": true in json config : Traceback (most recent call last): |
@devopssii related bug/issue to this issue |
@devopssii what LLM are you using? did you change the base prompt? Smaller LLM models might not be expressive enough yet to keep the required structure of generated output for successful parsing. This needs a solution but we are dealing with a stochastic ginny. https://github.com/filip-michalsky/SalesGPT/blob/main/salesgpt/parsers.py#L28
|
gpt-3.5-turbo. if use_tools false defaut agent must use tool with description jr not? because you def from_llm is static and not work dynamic |
whatever parsers is not working |
I faced the same problem, till this moment I have one line of code related to this problem at agents.py line 297. |
@Demian143 thanks for your input, actually it’s not expected by everyone to be boolean. when you use JSON agent config (per the example), the field gets read in as a string. Can you please help by submitting a PR to allow and effectively handle both in-code and JSON config input? I will get to it when I can but help would be appreciated. Thanks |
Sure, I'll try to fix it. |
Could you please send me an example case or reference of using a JSON agent config? |
Please see the readme: python run.py --verbose True --config examples/example_agent_setup.json |
thanks |
Fix #25 - pass `use_tools` as either arg or a string from loaded JSON config.
I am facing an implementation issue from your repository. I don't understand how it should work. If you leave use_tools: bool = False in agents.py, then this is just a chat with LLM that hallucinates due to prompts and does not use the product database, it just invents a trading conversation without connecting to a file with real product data. If you set use_tools: bool = True, then it immediately sends the first welcome message to the request, which is naturally not contained in the product database, and a negative response comes from parsers.py line 31 "output": "I apologize, I was unable to find the answer to your question. Is there anything else I can help with?". How do you solve this problem?
The text was updated successfully, but these errors were encountered: