regenerate CGO bindings + drop unused struct which referenced nonexistent abi type #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,122 @@ | |||
| { | |||
There was a problem hiding this comment.
why did you add these into this code base?
There was a problem hiding this comment.
why did you add these into this code base?
CircleCI uses this file (see the .circleci/config.yaml in this PR) to download Groth parameters. Previously, we were cargo install'ing paramcache and generating them ourselves based on a rust-fil-proofs Git SHA, which was a nightmare.
14 tasks
laser
added a commit
that referenced
this pull request
Apr 10, 2020
* update api from election post to winning post * add winning post api * generate new CGO bindings * happy clippyg * cleanup and add test for window post * windWOW.bizgit add . * basic adjustments to the go interface * gofmt * fix go tests * fix constants conversions * upate api * update to latest version * regenerate CGO bindings + drop unused struct which referenced non… (#73) * use latest specs-actors * generate new CGO bindings * delete now-dead types * fix warnings from oddly-formed format string * drop EligibleSectors field, which wasn't used / didn't exist * circleci to use go-paramfetch to download (instead of paramcache to generate) * linter said i had to delete you. sorry, toSectors * clippy made me do it * clippy says conversion wasn't necessary * clippy says reading to end of file is naughty * disable pesky gomodules for binary build * so annoying * write a dumb property test for GenerateWinningPoStSectorChallenge to ensure i'm not crazy * add failing property test * copy values from one memory space to the other Co-authored-by: laser <[email protected]>
gracenoah
pushed a commit
to gracenoah/filecoin-ffi
that referenced
this pull request
Dec 20, 2020
…in-project#69) * update api from election post to winning post * add winning post api * generate new CGO bindings * happy clippyg * cleanup and add test for window post * windWOW.bizgit add . * basic adjustments to the go interface * gofmt * fix go tests * fix constants conversions * upate api * update to latest version * regenerate CGO bindings + drop unused struct which referenced non… (filecoin-project#73) * use latest specs-actors * generate new CGO bindings * delete now-dead types * fix warnings from oddly-formed format string * drop EligibleSectors field, which wasn't used / didn't exist * circleci to use go-paramfetch to download (instead of paramcache to generate) * linter said i had to delete you. sorry, toSectors * clippy made me do it * clippy says conversion wasn't necessary * clippy says reading to end of file is naughty * disable pesky gomodules for binary build * so annoying * write a dumb property test for GenerateWinningPoStSectorChallenge to ensure i'm not crazy * add failing property test * copy values from one memory space to the other Co-authored-by: laser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things in PR
This changeset fixes the CGO compilation errors (mismatches between generated CGO and the header file) and the non-CGO errors, too.
This changeset also replaces the now-antiquated usage of paramcache with go-paramfetch, much like storage-fsm and the like.
It also updates some Rust issues that clippy caught.