forked from marionettejs/backbone.marionette
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature flags are added onto the Marionette.FEATURES object: ```js Marionette.FEATURES = { fooFlag: false }; ``` and are checked in the library code via a simple `isEnabled` check: ```js Marionette.isEnabled('fooFlag') ``` The goal of feature flags is to be able to add *breaking* features in a minor release behind a feature flag. There are two benefits to this strategy: 1) users can access the new feature immediately 2) the code can be merged onto master much sooner, which prevents higher risk merges down the road.
- Loading branch information
1 parent
94484e3
commit 4eaf14b
Showing
5 changed files
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Marionette.FEATURES = { | ||
}; | ||
|
||
Marionette.isEnabled = function(name) { | ||
return !!Marionette.FEATURES[name]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
describe('features', function() { | ||
|
||
beforeEach(function() { | ||
Marionette.FEATURES = {}; | ||
}); | ||
|
||
it('enabled when its present and true', function() { | ||
Marionette.FEATURES.foo = true; | ||
expect(Marionette.isEnabled('foo')).to.be.true; | ||
}); | ||
|
||
it('disabled when its present and false', function() { | ||
Marionette.FEATURES.foo = false; | ||
expect(Marionette.isEnabled('foo')).to.be.false; | ||
}); | ||
|
||
it('disabled when not present', function() { | ||
expect(Marionette.isEnabled('foo')).to.be.false; | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters