-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(types): add internalRewriteLocationHeader in ts types #335
Conversation
Signed-off-by: Valerian Crasnier <[email protected]>
looks good, but can you add a simple typing test please? |
Signed-off-by: Valerian Crasnier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nice, when do you think it's gonna be available to release ? Because rn some of my code is red due to the missing type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fastify/leads Time for a release :)? |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy) | [`9.4.0` -> `9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-http-proxy (@​fastify/http-proxy)</summary> ### [`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0) [Compare Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0) #### What's Changed - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334) - chore(types): add internalRewriteLocationHeader in ts types by [@​Xa3lis](https://togithub.com/Xa3lis) in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - build(deps-dev): bump [@​fastify/websocket](https://togithub.com/fastify/websocket) from 8.3.1 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337) - build(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 6.21.0 to 7.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339) - chore: remove unused make-promises-safe by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - Keep websocket path on proxy by [@​silnex](https://togithub.com/silnex) in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) #### New Contributors - [@​Xa3lis](https://togithub.com/Xa3lis) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - [@​silnex](https://togithub.com/silnex) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) **Full Changelog**: fastify/fastify-http-proxy@v9.4.0...v9.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy) | [`9.4.0` -> `9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-http-proxy (@​fastify/http-proxy)</summary> ### [`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0) [Compare Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0) #### What's Changed - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334) - chore(types): add internalRewriteLocationHeader in ts types by [@​Xa3lis](https://togithub.com/Xa3lis) in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - build(deps-dev): bump [@​fastify/websocket](https://togithub.com/fastify/websocket) from 8.3.1 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337) - build(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 6.21.0 to 7.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339) - chore: remove unused make-promises-safe by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - Keep websocket path on proxy by [@​silnex](https://togithub.com/silnex) in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) #### New Contributors - [@​Xa3lis](https://togithub.com/Xa3lis) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - [@​silnex](https://togithub.com/silnex) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) **Full Changelog**: fastify/fastify-http-proxy@v9.4.0...v9.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <[email protected]>
Hello,
The
internalRewriteLocationHeader
was added some months ago, it's working fine but the TS types had not been updated, so this is a quick PR to add itChecklist
npm run test
andnpm run benchmark
and the Code of conduct