Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Faker::Music::Opera.saint_saens issue #2792

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

devashishTaneja
Copy link
Contributor

@devashishTaneja devashishTaneja commented Jul 2, 2023

Motivation / Background

This Pull Request has been created because [REPLACE ME]

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

@devashishTaneja devashishTaneja changed the title Fix Faker::Music::Opera.saint_saens issue Fix #2786 Jul 2, 2023
@devashishTaneja
Copy link
Contributor Author

Fixes #2786

@devashishTaneja
Copy link
Contributor Author

@thdaraujo Please review and merge the PR

@devashishTaneja
Copy link
Contributor Author

@thdaraujo, @psibi can I get a review for this pr.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing it!

@devashishTaneja
Copy link
Contributor Author

@thdaraujo can you merge?

@thdaraujo thdaraujo mentioned this pull request Jul 5, 2023
4 tasks
@thdaraujo thdaraujo changed the title Fix #2786 Fixes Faker::Music::Opera.saint_saens issue Jul 5, 2023
@thdaraujo thdaraujo merged commit 58013e0 into faker-ruby:main Jul 5, 2023
7 checks passed
@devashishTaneja devashishTaneja deleted the issue-2786 branch July 5, 2023 19:03
@sudeeptarlekar
Copy link
Contributor

It would be nice to fix test cases in same PR, but its already merged...

@devashishTaneja
Copy link
Contributor Author

@sudeeptarlekar I will raise a separate PR for test case fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants